Skip to content

Fix Javadoc issues, hide more Error Prone warnings#10360

Merged
zbynek merged 7 commits into
gwtproject:mainfrom
zbynek:ep-javadoc
Jul 15, 2026
Merged

Fix Javadoc issues, hide more Error Prone warnings#10360
zbynek merged 7 commits into
gwtproject:mainfrom
zbynek:ep-javadoc

Conversation

@zbynek

@zbynek zbynek commented Jul 5, 2026

Copy link
Copy Markdown
Collaborator

As the Error Prone upgrade and filtering PRs were merged around the same time, compiling GWT now produces thousands of warnings. This PR adds more suppressios and fixes warnings related to Javadoc.

Fixes #8428

@zbynek zbynek added the ready This PR has been reviewed by a maintainer and is ready for a CI run. label Jul 5, 2026

@niloc132 niloc132 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can probably close (or at least reference) #8428 in the description

Comment thread user/src/com/google/gwt/dom/client/MediaElement.java Outdated
Comment thread user/src/com/google/gwt/dom/client/Touch.java Outdated
Comment thread user/src/com/google/gwt/event/dom/client/TouchEvent.java Outdated
Comment thread user/src/com/google/web/bindery/autobean/vm/impl/FactoryHandler.java Outdated
Co-authored-by: Colin Alworth <colin@vertispan.com>
@niloc132 niloc132 added this to the 2.14 milestone Jul 9, 2026
@zbynek

zbynek commented Jul 10, 2026

Copy link
Copy Markdown
Collaborator Author

Can probably close (or at least reference) #8428 in the description

I got a bit closer to that by resolving the remaining issues spotted by Error Prone.

There are still 86 issues reported in console by the Javadoc task (down from 100+).

@niloc132

Copy link
Copy Markdown
Member

Do you want to finish them up, or maybe still link and mark as partial? I'd generally love to get to the point of having tickets for many/most changes just as a practical matter.

@zbynek

zbynek commented Jul 10, 2026

Copy link
Copy Markdown
Collaborator Author

If you don't mind this PR getting bigger, I'll fix them here.

@niloc132

Copy link
Copy Markdown
Member

Go for it - I've read each change (and marked as read) so incremental additions won't be too bad.

@zbynek
zbynek force-pushed the ep-javadoc branch 2 times, most recently from 1ce5e73 to 9e0e4f5 Compare July 11, 2026 09:12
@zbynek
zbynek requested a review from niloc132 July 11, 2026 14:35
Comment thread dev/core/src/com/google/gwt/core/ext/typeinfo/JType.java Outdated
Comment thread user/src/com/google/gwt/resources/gss/GwtGssFunctionMapProvider.java Outdated
Comment thread user/src/com/google/gwt/resources/gss/ImageSpriteCreator.java
Comment thread user/src/com/google/gwt/uibinder/elementparsers/IsRenderableInterpreter.java Outdated
Comment thread user/src/com/google/gwt/uibinder/elementparsers/WidgetPlaceholderInterpreter.java Outdated
Comment thread user/src/com/google/gwt/user/server/rpc/RPC.java Outdated
@zbynek
zbynek requested a review from niloc132 July 15, 2026 18:18
@niloc132

Copy link
Copy Markdown
Member

Do we still want to consider this a partial fix? I count 18 warnings in the build related to javadoc, all apply to build/out/user/jakarta-src/com/google/gwt/user/server/rpc/jakarta/XsrfTokenServiceServlet.java - to be fair, the file is copied so we could either fix or just punt and call the rest fixed?

@zbynek

zbynek commented Jul 15, 2026

Copy link
Copy Markdown
Collaborator Author

Description updated to full fix. To get rid of the Jakarta warnings we'd have to do some more replacements in the ant script that builds it, and I think we should not increase ant file complexity before the Maven migration.

@zbynek
zbynek merged commit 6936cfb into gwtproject:main Jul 15, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready This PR has been reviewed by a maintainer and is ready for a CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix javadoc warnings

2 participants