add CompatibleNullPool to handle pool sizing arguments and associated tests

Author: Eugene Shershen

psqlpy_sqlalchemy/dialect.py

@@ -17,16 +17,19 @@
 class CompatibleNullPool(NullPool):
     """
     A NullPool wrapper that accepts but ignores pool sizing arguments.
-    
+
     This class is used to maintain compatibility with middleware that passes
     pool_size and max_overflow arguments, which are not valid for NullPool
     but are commonly passed by frameworks like FastAPI with fastapi_async_sqlalchemy.
     """
-    
+
     def __init__(self, creator, pool_size=None, max_overflow=None, **kw):
         # Filter out pool sizing arguments that NullPool doesn't accept
-        filtered_kw = {k: v for k, v in kw.items() 
-                      if k not in ('pool_size', 'max_overflow')}
+        filtered_kw = {
+            k: v
+            for k, v in kw.items()
+            if k not in ("pool_size", "max_overflow")
+        }
         super().__init__(creator, **filtered_kw)
 
 
@@ -278,7 +281,6 @@ def _isolation_lookup(self) -> Dict[str, Any]:
             "SERIALIZABLE": psqlpy.IsolationLevel.Serializable,
         }
 
-
     def create_connect_args(
         self,
         url: URL,
@@ -324,4 +326,4 @@ def get_deferrable(self, connection):
 PsqlpyDialect = PSQLPyAsyncDialect
 
 # Export the compatible pool class for users who need it
-__all__ = ['PSQLPyAsyncDialect', 'PsqlpyDialect', 'CompatibleNullPool']
+__all__ = ["PSQLPyAsyncDialect", "PsqlpyDialect", "CompatibleNullPool"]

tests/test_poolclass_compatibility.py

@@ -12,7 +12,11 @@
 from sqlalchemy.ext.asyncio import create_async_engine
 from sqlalchemy.pool import AsyncAdaptedQueuePool, NullPool, QueuePool
 
-from psqlpy_sqlalchemy.dialect import PSQLPyAsyncDialect, PsqlpyDialect, CompatibleNullPool
+from psqlpy_sqlalchemy.dialect import (
+    CompatibleNullPool,
+    PSQLPyAsyncDialect,
+    PsqlpyDialect,
+)
 
 
 class TestPoolclassCompatibility(unittest.TestCase):
@@ -223,7 +227,9 @@ def test_compatible_nullpool_with_pool_args_sync(self):
         except Exception as e:
             # Connection errors are acceptable, we're testing pool creation
             if "Invalid argument(s)" in str(e):
-                self.fail(f"CompatibleNullPool should accept pool arguments: {e}")
+                self.fail(
+                    f"CompatibleNullPool should accept pool arguments: {e}"
+                )
 
     def test_compatible_nullpool_with_pool_args_async(self):
         """Test that CompatibleNullPool works with pool arguments in async engines"""
@@ -238,13 +244,16 @@ async def _test_compatible_nullpool():
                 )
                 self.assertIsNotNone(self.async_engine)
                 self.assertEqual(
-                    self.async_engine.sync_engine.pool.__class__, CompatibleNullPool
+                    self.async_engine.sync_engine.pool.__class__,
+                    CompatibleNullPool,
                 )
                 return True
             except Exception as e:
                 # Connection errors are acceptable, we're testing pool creation
                 if "Invalid argument(s)" in str(e):
-                    self.fail(f"CompatibleNullPool should accept pool arguments: {e}")
+                    self.fail(
+                        f"CompatibleNullPool should accept pool arguments: {e}"
+                    )
                 return True
 
         loop = asyncio.new_event_loop()
@@ -270,7 +279,9 @@ def test_compatible_nullpool_ignores_pool_args(self):
         except Exception as e:
             # Connection errors are acceptable
             if "Invalid argument(s)" in str(e):
-                self.fail(f"CompatibleNullPool should ignore pool arguments: {e}")
+                self.fail(
+                    f"CompatibleNullPool should ignore pool arguments: {e}"
+                )
 
     def test_regular_nullpool_still_fails_with_pool_args(self):
         """Test that regular NullPool still fails with pool arguments (regression test)"""
@@ -281,8 +292,11 @@ def test_regular_nullpool_still_fails_with_pool_args(self):
                 pool_size=5,
                 max_overflow=10,
             )
-        
-        self.assertIn("Invalid argument(s) 'pool_size','max_overflow'", str(context.exception))
+
+        self.assertIn(
+            "Invalid argument(s) 'pool_size','max_overflow'",
+            str(context.exception),
+        )
 
 
 class TestFastAPIMiddlewareCompatibility(unittest.TestCase):