Skip to content

Commit e8f1972

Browse files
author
Eugene Shershen
committed
refactor type hints to use new syntax; update Optional to use union types for better clarity
1 parent aa2178b commit e8f1972

1 file changed

Lines changed: 6 additions & 7 deletions

File tree

tests/test_sqlmodel_compatibility.py

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@
44
"""
55

66
import unittest
7-
from typing import Optional
87

98
from sqlalchemy import create_engine
109
from sqlmodel import Field, Session, SQLModel, select
@@ -13,10 +12,10 @@
1312
class Hero(SQLModel, table=True):
1413
"""Test model for SQLModel compatibility tests"""
1514

16-
id: Optional[int] = Field(default=None, primary_key=True)
15+
id: int | None = Field(default=None, primary_key=True)
1716
name: str
1817
secret_name: str
19-
age: Optional[int] = None
18+
age: int | None = None
2019

2120

2221
class TestSQLModelCompatibility(unittest.TestCase):
@@ -120,16 +119,16 @@ def test_sqlmodel_relationships(self):
120119
"""Test SQLModel relationship handling"""
121120

122121
class Team(SQLModel, table=True):
123-
id: Optional[int] = Field(default=None, primary_key=True)
122+
id: int | None = Field(default=None, primary_key=True)
124123
name: str
125124
headquarters: str
126125

127126
class HeroWithTeam(SQLModel, table=True):
128-
id: Optional[int] = Field(default=None, primary_key=True)
127+
id: int | None = Field(default=None, primary_key=True)
129128
name: str
130129
secret_name: str
131-
age: Optional[int] = None
132-
team_id: Optional[int] = Field(default=None, foreign_key="team.id")
130+
age: int | None = None
131+
team_id: int | None = Field(default=None, foreign_key="team.id")
133132

134133
# Create tables for these models
135134
Team.metadata.create_all(self.engine)

0 commit comments

Comments
 (0)