Add some file types from the Go version#41
Conversation
|
Hey, @h2non what we need to do to merge this PR? Maybe I can help 🙂 |
|
https://github.com/h2non/filetype.py/pull/41/files#diff-ad453f8a0e9dcc5a7320fb8fa6e98de5R96-R99 all doc, xls and ppt are have the same file signature, so no matter which one checked will always detected as a :edit: so here i am confused about how to implement this for ms office document types. :update: |
| - **ttf** - ``application/font-sfnt`` | ||
| - **otf** - ``application/font-sfnt`` | ||
|
|
||
| Document |
There was a problem hiding this comment.
Group microsoft office pre 2007 documents as application/x-ole-storage as this 3 types have same file signatures. We can determine the file type by filename extension.
|
|
||
| # Supported application types | ||
| DOCUMENT = ( | ||
| document.Doc(), |
There was a problem hiding this comment.
Doc type it will valid for xls and ppt because of same file signature, so no need to define the others.
Added some low hanging fruit file types from the Go version. Put Dcm under archive (as on the Go side). Didn't improve matroska detection or add docx, xlsx or pptx. Nice lib ^^.