Add negation of relative existence queries#168
Open
jg-rp wants to merge 1 commit into
Open
Conversation
Collaborator
|
@jg-rp Thanks! One issue is that your change to the find function can cause returning a boolean instead of a list of results. I think something like the below should work. if self.op == "!":
# Negated relative query existence test
- return not datum
+ if not datum:
+ return [datum]
+ else:
+ return [] |
Collaborator
|
It would also be nice if you could add your example above to the README. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request implements the not operator (
!) for negating a relative query when testing for existence. This is a potential solution for #167.Sticking with example data from #167, this example selects values from
datathat don't contain atypeproperty.To keep this PR small, I've deliberately avoided implementing logical negation for other filter expression types and any refactoring of
ext.filter.Expression.