[Breaking] Rename callback setters to setCallbacks, taking a reference only

Author: h2zero

examples/ANCS/ANCS.ino

@@ -120,7 +120,7 @@ void setup() {
     NimBLEDevice::setPower(9);
 
     NimBLEServer* pServer = NimBLEDevice::createServer();
-    pServer->setCallbacks(&serverCallbacks);
+    pServer->setCallbacks(serverCallbacks);
     pServer->advertiseOnDisconnect(true);
 
     NimBLEAdvertising*      pAdvertising = pServer->getAdvertising();

examples/Bluetooth_5/NimBLE_extended_client/NimBLE_extended_client.ino

@@ -57,7 +57,7 @@ bool connectToServer() {
     NimBLEClient* pClient = nullptr;
 
     pClient = NimBLEDevice::createClient();
-    pClient->setClientCallbacks(&clientCallbacks, false);
+    pClient->setCallbacks(clientCallbacks);
 
     /**
      * Set the PHY's to use for this connection. This is a bitmask that represents the PHY's:

examples/Bluetooth_5/NimBLE_extended_server/NimBLE_extended_server.ino

@@ -89,7 +89,7 @@ void setup() {
 
     /** Create the server and add the services/characteristics/descriptors */
     NimBLEServer* pServer = NimBLEDevice::createServer();
-    pServer->setCallbacks(&serverCallbacks);
+    pServer->setCallbacks(serverCallbacks);
 
     NimBLEService*        pService = pServer->createService(SERVICE_UUID);
     NimBLECharacteristic* pCharacteristic =
@@ -125,7 +125,7 @@ void setup() {
     NimBLEExtAdvertising* pAdvertising = NimBLEDevice::getAdvertising();
 
     /** Set the callbacks for advertising events */
-    pAdvertising->setCallbacks(&advertisingCallbacks);
+    pAdvertising->setCallbacks(advertisingCallbacks);
 
     /**
      *  NimBLEExtAdvertising::setInstanceData takes the instance ID and

examples/Bluetooth_5/NimBLE_multi_advertiser/NimBLE_multi_advertiser.ino

@@ -107,7 +107,7 @@ void setup() {
 
     /** Create a server for our legacy advertiser */
     NimBLEServer* pServer = NimBLEDevice::createServer();
-    pServer->setCallbacks(&serverCallbacks);
+    pServer->setCallbacks(serverCallbacks);
 
     NimBLEService*        pService = pServer->createService(SERVICE_UUID);
     NimBLECharacteristic* pCharacteristic =
@@ -155,7 +155,7 @@ void setup() {
     NimBLEExtAdvertising* pAdvertising = NimBLEDevice::getAdvertising();
 
     /** Set the callbacks to handle advertising events */
-    pAdvertising->setCallbacks(&advCallbacks);
+    pAdvertising->setCallbacks(advCallbacks);
 
     /**
      *  Set instance data.

examples/L2CAP/L2CAP_Client/L2CAP_Client.ino

@@ -106,7 +106,7 @@ void loop() {
     if (!theClient) {
         theClient = NimBLEDevice::createClient();
         theClient->setConnectionParams(6, 6, 0, 42);
-        theClient->setClientCallbacks(&clientCallbacks);
+        theClient->setCallbacks(clientCallbacks);
         if (!theClient->connect(theDevice)) {
             Serial.println("Error: Could not connect to device");
             return;

examples/L2CAP/L2CAP_Server/L2CAP_Server.ino

@@ -65,7 +65,7 @@ void setup() {
     auto channel   = cocServer->createService(L2CAP_CHANNEL, L2CAP_MTU, &l2capCallbacks);
 
     auto server = NimBLEDevice::createServer();
-    server->setCallbacks(&gattCallbacks);
+    server->setCallbacks(gattCallbacks);
 
     auto service        = server->createService(SERVICE_UUID);
     auto characteristic = service->createCharacteristic(CHARACTERISTIC_UUID, NIMBLE_PROPERTY::READ);

examples/NimBLE_Async_Client/NimBLE_Async_Client.ino

@@ -40,7 +40,7 @@ class ScanCallbacks : public NimBLEScanCallbacks {
                 }
             }
 
-            pClient->setClientCallbacks(&clientCallbacks, false);
+            pClient->setCallbacks(clientCallbacks);
             if (!pClient->connect(true, true, false)) { // delete attributes, async connect, no MTU exchange
                 NimBLEDevice::deleteClient(pClient);
                 Serial.printf("Failed to connect\n");

examples/NimBLE_Client/NimBLE_Client.ino

@@ -122,7 +122,7 @@ bool connectToServer() {
 
         Serial.printf("New client created\n");
 
-        pClient->setClientCallbacks(&clientCallbacks, false);
+        pClient->setCallbacks(clientCallbacks);
         /**
          *  Set initial connection parameters:
          *  These settings are safe for 3 clients to connect reliably, can go faster if you have less

examples/NimBLE_Secure_Client/NimBLE_Secure_Client.ino

@@ -43,7 +43,7 @@ void setup() {
 
         if (device->isAdvertisingService(serviceUuid)) {
             NimBLEClient* pClient = NimBLEDevice::createClient();
-            pClient->setClientCallbacks(&clientCallbacks, false);
+            pClient->setCallbacks(clientCallbacks);
 
             if (pClient->connect(&device)) {
                 pClient->secureConnection();

examples/NimBLE_Server/NimBLE_Server.ino

@@ -147,7 +147,7 @@ void setup(void) {
     // NimBLEDevice::setSecurityAuth(BLE_SM_PAIR_AUTHREQ_BOND | BLE_SM_PAIR_AUTHREQ_MITM | BLE_SM_PAIR_AUTHREQ_SC);
 
     pServer = NimBLEDevice::createServer();
-    pServer->setCallbacks(&serverCallbacks);
+    pServer->setCallbacks(serverCallbacks);
 
     NimBLEService*        pDeadService = pServer->createService("DEAD");
     NimBLECharacteristic* pBeefCharacteristic =
@@ -159,7 +159,7 @@ void setup(void) {
         );
 
     pBeefCharacteristic->setValue("Burger");
-    pBeefCharacteristic->setCallbacks(&chrCallbacks);
+    pBeefCharacteristic->setCallbacks(chrCallbacks);
 
     /**
      *  2902 and 2904 descriptors are a special case, when createDescriptor is called with
@@ -169,22 +169,22 @@ void setup(void) {
      */
     NimBLE2904* pBeef2904 = pBeefCharacteristic->create2904();
     pBeef2904->setFormat(NimBLE2904::FORMAT_UTF8);
-    pBeef2904->setCallbacks(&dscCallbacks);
+    pBeef2904->setCallbacks(dscCallbacks);
 
     NimBLEService*        pBaadService = pServer->createService("BAAD");
     NimBLECharacteristic* pFoodCharacteristic =
         pBaadService->createCharacteristic("F00D", NIMBLE_PROPERTY::READ | NIMBLE_PROPERTY::WRITE | NIMBLE_PROPERTY::NOTIFY);
 
     pFoodCharacteristic->setValue("Fries");
-    pFoodCharacteristic->setCallbacks(&chrCallbacks);
+    pFoodCharacteristic->setCallbacks(chrCallbacks);
 
     /** Custom descriptor: Arguments are UUID, Properties, max length of the value in bytes */
     NimBLEDescriptor* pC01Ddsc =
         pFoodCharacteristic->createDescriptor("C01D",
                                               NIMBLE_PROPERTY::READ | NIMBLE_PROPERTY::WRITE | NIMBLE_PROPERTY::WRITE_ENC,
                                               20);
     pC01Ddsc->setValue("Send it back!");
-    pC01Ddsc->setCallbacks(&dscCallbacks);
+    pC01Ddsc->setCallbacks(dscCallbacks);
 
     /** Create an advertising instance and add the services to the advertised data */
     NimBLEAdvertising* pAdvertising = NimBLEDevice::getAdvertising();