Skip to content

Commit e46993b

Browse files
break infinite loop
1 parent a548a18 commit e46993b

1 file changed

Lines changed: 8 additions & 3 deletions

File tree

h5p.classes.php

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1028,12 +1028,17 @@ public function isValidPackage($skipContent = FALSE, $upgradeOnly = FALSE) {
10281028
}
10291029
}
10301030
while ($missingLibraries = $this->getMissingLibraries($upgrades)) {
1031+
$foundOne = false;
10311032
foreach ($missingLibraries as $libString => $missing) {
1032-
if (array_key_exists($libString, $libraries)){
1033-
$library = $libraries[$libString];
1034-
$upgrades[$libString] = $library;
1033+
if (array_key_exists($libString, $libraries)) {
1034+
$upgrades[$libString] = $libraries[$libString];
1035+
$foundOne = true;
10351036
}
10361037
}
1038+
// Break if we didn't find any new libraries to add (prevents infinite loop)
1039+
if (!$foundOne) {
1040+
break;
1041+
}
10371042
}
10381043

10391044
$libraries = $upgrades;

0 commit comments

Comments
 (0)