HFP-3649 Fix confirmation dialog button positioning#144
Open
otacke wants to merge 1 commit into
Open
Conversation
otacke
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Safari's user agent style for
buttonelements adds a horizontal padding of1emwhich usually translates to16px. That puts the confirmation dialogs exit button out of place looking very weird.When merged in, will apply a padding value of
1px 6pxwhich is Blink's user agent style for padding ofbuttonelements and seems to have been the targeted platform to have checked against - thus looking fine (even though the while confirmation dialog visuals might need some overhaul :-)).