HFP-3650 Fix semi-fullscreen impact by integration CSS#145
Open
otacke wants to merge 2 commits into
Open
Conversation
otacke
changed the title
otacke
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When H5P core sends content into
semi-fullscreenmode, the stylesheet of the platform (e.g. WordPress) may impact the iframe style and prevent a fullscreen look.When merged in, the iframe with
semi-fullscreenselector will getmarginandpaddingset to0in order to overrule the styling set by the H5P integration. Also, the background color will explicitly set to #fff in order to overrule the platform's background color setting in semi-fullscreen mode.