feat: add partial update support#331
Open
janlay wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds partial update support for WebDAV clients that require range-based writes, especially
webdavfs.This includes support for:
PATCHwithX-Update-RangePUTwithContent-Rangesabredav-partialupdatevia theDAVresponse headerAccept-Patch: application/x-sabredav-partialupdateMotivation
Some WebDAV clients, such as
miquels/webdavfs, probe for PUT range support before mounting read-write. Without partial update support, they fall back to read-only mode with:Advertising and implementing SabreDAV-style partial updates allows these clients to mount read-write.
Changes
Testing
go test ./...
go build -o webdav .
Also manually verified with webdavfs on Debian:
sudo mount -t webdavfs -o"username=user,password=pass,allow_other,rw" http://10.0.0.2:6065 /mnt/testThe mount succeeds as read-write and no longer reports missing PUT range support. A mounted-file partial overwrite test also passed.