reduce flickering on login#179
Open
maxx06 wants to merge 1 commit intohack-duke:masterfrom
Open
Conversation
👷 Deploy request for hackduke-portal pending review.Visit the deploys page to approve it
|
linrally
requested changes
Oct 20, 2025
| <div className="form-container"> | ||
| <MultiPageForm onSubmit={onSubmit}> | ||
| {!loading && ( | ||
| <div className="form-container"> |
Contributor
There was a problem hiding this comment.
Can you explain what you are doing here? How does not rendering the form container when loading fix the flickering issue? Aren't we still redirecting to this page for a second before the right one?
Contributor
|
Tbh maybe we should just add an animation when you change pages |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
remove application link in status page and reduce flickering when login
Fixes #103