120 jest tests for recipe page#159
Closed
kjdiaz508 wants to merge 8 commits into
Closed
Conversation
…ack4impact-calpoly/meals-that-connect-25 into 120-jest-tests-for-recipe-page
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Developer: Kevin Diaz
Closes #120
Pull Request Summary
More API tests for the recipe/combo API. Not yet with updated schema, just opening the PR for reference.
Could verify that what the tests are doing makes sense, and I will update for new schema later.
Modifications
__tests__/*: added more tests, such as testing draft logic, sorting, updating, searching, etc. for both combos and recipes.Testing Considerations
ran the tests, all pass. One minor logic bug is caused by the schema currently having both allergens and filters, but I'm guessing that will go away.
Pull Request Checklist
Screenshots/Screencast