[XSS] Fixed choice manager UI bug (thanks barbaz for report).

hackademix · hackademix · commit 4afa2a7435e1 · 2021-01-25T21:25:38.000+01:00
diff --git a/src/ui/ui.js b/src/ui/ui.js
@@ -174,9 +174,9 @@ var UI = (() => {
       }
       button.onclick = () => {
         let xssUserChoices = UI.xssUserChoices;
-        for (let o of list.selectedOptions) {
+        for (let o of [...list.selectedOptions]) {
           delete xssUserChoices[o.value];
-          list.remove(o);
+          o.remove();
         }
         if (list.options.length === 0) {
           choicesUI.classList.remove("populated");

Original file line number	Diff line number	Diff line change
`@@ -174,9 +174,9 @@ var UI = (() => {`
`174`	`174`	`}`
`175`	`175`	`button.onclick = () => {`
`176`	`176`	`let xssUserChoices = UI.xssUserChoices;`
`177`		`- for (let o of list.selectedOptions) {`
	`177`	`+ for (let o of [...list.selectedOptions]) {`
`178`	`178`	`delete xssUserChoices[o.value];`
`179`		`- list.remove(o);`
	`179`	`+ o.remove();`
`180`	`180`	`}`
`181`	`181`	`if (list.options.length === 0) {`
`182`	`182`	`choicesUI.classList.remove("populated");`