new thingo's for admin dash (#242)

Author: aaravjhamb

app/controllers/admin/metrics_controller.rb

@@ -121,6 +121,8 @@ def index
       }
     }
 
+    review_stats = review_metrics(start_date.beginning_of_day..today.end_of_day)
+
     render inertia: "Admin/Metrics/Index", props: {
       range_days: days,
       summary: {
@@ -158,7 +160,56 @@ def index
       },
       referral_economy: referral_economy,
       reel_economy: reel_economy,
-      location_distribution: location_distribution
+      location_distribution: location_distribution,
+      reviews: review_stats
+    }
+  end
+
+  private
+
+  # Review throughput for completed reviews in the given window:
+  #   - avg_active_seconds:    heartbeat-measured hands-on review time per review
+  #   - avg_wall_seconds:      open → decision wall-clock per review
+  #   - avg_turnaround_seconds: builder submit → reviewer decision (queue + review)
+  def review_metrics(window)
+    completed = ReviewSession.completed.where(ended_at: window)
+    completed_count = completed.count
+    avg_active = completed.average(:active_seconds).to_f.round
+
+    wall_total = 0
+    completed.where.not(started_at: nil).pluck(:started_at, :ended_at).each do |started_at, ended_at|
+      wall_total += (ended_at - started_at).to_i
+    end
+    avg_wall = completed_count.positive? ? (wall_total / completed_count) : 0
+
+    decision_actions = %w[project.approved project.returned project.rejected project.pitch_approved]
+    decisions = AuditEvent
+      .where(action: decision_actions, target_type: "Project", created_at: window)
+      .pluck(:target_id, :created_at)
+
+    subs_by_project = AuditEvent
+      .where(action: "project.submitted_for_review", target_type: "Project", target_id: decisions.map(&:first).uniq)
+      .pluck(:target_id, :created_at)
+      .group_by(&:first)
+      .transform_values { |rows| rows.map(&:last) }
+
+    turnaround_total = 0
+    turnaround_count = 0
+    decisions.each do |project_id, decided_at|
+      submitted_at = subs_by_project[project_id]&.select { |t| t <= decided_at }&.max
+      next unless submitted_at
+
+      turnaround_total += (decided_at - submitted_at).to_i
+      turnaround_count += 1
+    end
+    avg_turnaround = turnaround_count.positive? ? (turnaround_total / turnaround_count) : 0
+
+    {
+      completed: completed_count,
+      avg_active_seconds: avg_active,
+      avg_wall_seconds: avg_wall,
+      avg_turnaround_seconds: avg_turnaround,
+      turnaround_sample: turnaround_count
     }
   end
 end

app/controllers/admin/projects_controller.rb

@@ -26,7 +26,7 @@ def index
   def pitches
     scope = policy_scope(Project).includes(:user, :ships).kept.where(status: :pitch_pending)
     scope = scope.search(params[:query]) if params[:query].present?
-    @pagy, @projects = pagy(scope.order(created_at: :desc))
+    @pagy, @projects = pagy(scope.order(created_at: :asc))
 
     render inertia: "Admin/Projects/Index", props: {
       projects: @projects.map { |p| serialize_project_row(p) },

app/controllers/admin/review_audits_controller.rb

@@ -3,11 +3,9 @@ class Admin::ReviewAuditsController < Admin::ApplicationController
   before_action :set_session, only: [ :show ]
 
   def index
-    scope = ReviewSession.includes(:reviewer, :project).order(started_at: :desc)
+    scope = ReviewSession.completed.includes(:reviewer, :project).order(ended_at: :desc)
     scope = scope.where(reviewer_id: params[:reviewer_id]) if params[:reviewer_id].present?
     scope = scope.where(project_id: params[:project_id]) if params[:project_id].present?
-    scope = scope.where(decision: nil) if params[:status] == "open"
-    scope = scope.where.not(decision: nil) if params[:status] == "closed"
 
     @pagy, @sessions = pagy(scope)
 
@@ -16,8 +14,7 @@ def index
       pagy: pagy_props(@pagy),
       filters: {
         reviewer_id: params[:reviewer_id].to_s,
-        project_id: params[:project_id].to_s,
-        status: params[:status].to_s
+        project_id: params[:project_id].to_s
       },
       totals: aggregate_totals
     }
@@ -53,7 +50,7 @@ def window_for(session)
   end
 
   def aggregate_totals
-    base = ReviewSession.all
+    base = ReviewSession.completed
     by_active = base.group(:reviewer_id).sum(:active_seconds)
     counts = base.group(:reviewer_id).count
 
@@ -72,7 +69,7 @@ def aggregate_totals
         reviewer_name: names[id] || "Unknown",
         active_seconds: by_active[id] || 0,
         wall_seconds: wall_by_id[id] || 0,
-        sessions_count: counts[id] || 0
+        reviews_count: counts[id] || 0
       }
     end
   end

app/javascript/pages/Admin/Metrics/Index.tsx

@@ -72,6 +72,14 @@ interface ReelEconomy {
   total_coins: number
 }
 
+interface ReviewStats {
+  completed: number
+  avg_active_seconds: number
+  avg_wall_seconds: number
+  avg_turnaround_seconds: number
+  turnaround_sample: number
+}
+
 interface CountryRow {
   country: string
   count: number
@@ -118,6 +126,17 @@ function CountryBars({ rows, total }: { rows: CountryRow[]; total: number }) {
   )
 }
 
+function formatDuration(s: number): string {
+  if (!s || s <= 0) return '—'
+  const d = Math.floor(s / 86400)
+  const h = Math.floor((s % 86400) / 3600)
+  const m = Math.floor((s % 3600) / 60)
+  if (d > 0) return `${d}d ${h}h`
+  if (h > 0) return `${h}h ${m}m`
+  if (m > 0) return `${m}m ${s % 60}s`
+  return `${s}s`
+}
+
 function Stat({ label, value, hint, accent }: { label: string; value: string | number; hint?: string; accent?: boolean }) {
   return (
     <Card>
@@ -143,6 +162,7 @@ export default function AdminMetricsIndex({
   referral_economy,
   reel_economy,
   location_distribution,
+  reviews,
 }: {
   range_days: number
   summary: Summary
@@ -156,6 +176,7 @@ export default function AdminMetricsIndex({
   referral_economy: ReferralEconomy
   reel_economy: ReelEconomy
   location_distribution: LocationDistribution
+  reviews: ReviewStats
 }) {
   const max = Math.max(1, ...daily.map((d) => d.count))
   const maxHours = Math.max(1, ...daily_hours.map((d) => d.hours))
@@ -285,6 +306,20 @@ export default function AdminMetricsIndex({
         </div>
       </div>
 
+      <div className="space-y-2">
+        <h2 className="text-sm font-semibold tracking-wide uppercase text-muted-foreground">Reviews — last {range_days} days</h2>
+        <div className="grid grid-cols-2 md:grid-cols-4 gap-3">
+          <Stat label="Reviews completed" value={reviews.completed} hint="decisions made in range" accent />
+          <Stat label="Avg review time" value={formatDuration(reviews.avg_active_seconds)} hint="active (heartbeat) time per review" />
+          <Stat label="Avg open → decision" value={formatDuration(reviews.avg_wall_seconds)} hint="reviewer opened until decided" />
+          <Stat
+            label="Avg submit → decision"
+            value={formatDuration(reviews.avg_turnaround_seconds)}
+            hint={`builder submit until decided · n=${reviews.turnaround_sample}`}
+          />
+        </div>
+      </div>
+
       <Card>
         <CardHeader>
           <CardTitle>Coin economy by tier</CardTitle>

app/javascript/pages/Admin/ReviewAudits/Index.tsx

@@ -25,15 +25,9 @@ interface ReviewerTotal {
   reviewer_name: string
   active_seconds: number
   wall_seconds: number
-  sessions_count: number
+  reviews_count: number
 }
 
-const filters = [
-  { key: '', label: 'All' },
-  { key: 'open', label: 'Open (in-progress)' },
-  { key: 'closed', label: 'Closed' },
-]
-
 function decisionBadge(decision: string | null) {
   if (!decision) return <Badge variant="warning">in progress</Badge>
   switch (decision) {
@@ -76,7 +70,7 @@ function Leaderboard({
               <TableHead>Reviewer</TableHead>
               <TableHead>Active</TableHead>
               <TableHead>Wall</TableHead>
-              <TableHead className="text-right">Sessions</TableHead>
+              <TableHead className="text-right">Reviews</TableHead>
             </TableRow>
           </TableHeader>
           <TableBody>
@@ -102,7 +96,7 @@ function Leaderboard({
                 <TableCell className={cn('font-mono text-sm', sortKey === 'wall_seconds' && 'font-semibold')}>
                   {formatSeconds(t.wall_seconds)}
                 </TableCell>
-                <TableCell className="text-right font-mono text-xs">{t.sessions_count}</TableCell>
+                <TableCell className="text-right font-mono text-xs">{t.reviews_count}</TableCell>
               </TableRow>
             ))}
           </TableBody>
@@ -120,7 +114,7 @@ export default function ReviewAuditsIndex({
 }: {
   sessions: SessionRow[]
   pagy: PagyProps
-  filters: { reviewer_id: string; project_id: string; status: string }
+  filters: { reviewer_id: string; project_id: string }
   totals: ReviewerTotal[]
 }) {
   function applyFilter(key: string, value: string) {
@@ -135,65 +129,51 @@ export default function ReviewAuditsIndex({
           Review Audits
         </h1>
         <p className="text-sm text-muted-foreground mt-1">
-          Every review session ever opened — reviewer, project, active seconds, and a full audit trail of what happened. Superadmin only.
+          Every completed review — reviewer, project, active seconds, and a full audit trail of what happened. Superadmin only.
         </p>
       </div>
 
       {totals.length === 0 ? (
         <Card>
-          <CardContent className="p-6 text-sm text-muted-foreground text-center">No closed sessions yet.</CardContent>
+          <CardContent className="p-6 text-sm text-muted-foreground text-center">No completed reviews yet.</CardContent>
         </Card>
       ) : (
         <div className="grid grid-cols-1 md:grid-cols-2 gap-4">
           <Leaderboard
             title="Active time leaderboard"
-            description="Sum of heartbeat-measured active time across all sessions. The basis for reviewer payouts."
+            description="Sum of heartbeat-measured active time across completed reviews. The basis for reviewer payouts."
             totals={totals}
             sortKey="active_seconds"
             onPickReviewer={(id) => applyFilter('reviewer_id', String(id))}
           />
           <Leaderboard
             title="Wall-clock leaderboard"
-            description="Sum of started_at→ended_at durations across all sessions. Includes idle/AFK time. Use the gap vs active to spot inefficient reviewers."
+            description="Sum of started_at→ended_at durations across completed reviews. Includes idle/AFK time. Use the gap vs active to spot inefficient reviewers."
             totals={totals}
             sortKey="wall_seconds"
             onPickReviewer={(id) => applyFilter('reviewer_id', String(id))}
           />
         </div>
       )}
 
-      <div className="flex gap-2 flex-wrap items-center">
-        {filters.map((opt) => (
-          <button
-            key={opt.key}
-            onClick={() => applyFilter('status', opt.key)}
-            className={cn(
-              'px-3 py-1.5 text-xs font-medium rounded-md border transition-colors cursor-pointer',
-              f.status === opt.key
-                ? 'bg-primary text-primary-foreground border-primary'
-                : 'border-border bg-background text-muted-foreground hover:bg-accent hover:text-foreground',
-            )}
-          >
-            {opt.label}
-          </button>
-        ))}
-        {(f.reviewer_id || f.project_id) && (
+      {(f.reviewer_id || f.project_id) && (
+        <div className="flex gap-2 flex-wrap items-center">
           <button
             onClick={() => router.get('/admin/review_audits')}
             className="text-xs text-muted-foreground hover:text-foreground cursor-pointer underline"
           >
             clear filters
           </button>
-        )}
-      </div>
+        </div>
+      )}
 
       <Card>
         <CardHeader>
-          <CardTitle>Sessions</CardTitle>
+          <CardTitle>Completed reviews</CardTitle>
         </CardHeader>
         <CardContent className="space-y-4">
           {sessions.length === 0 ? (
-            <p className="text-sm text-muted-foreground py-10 text-center">No sessions match.</p>
+            <p className="text-sm text-muted-foreground py-10 text-center">No completed reviews match.</p>
           ) : (
             <Table>
               <TableHeader>

app/models/review_session.rb

@@ -32,6 +32,7 @@ class ReviewSession < ApplicationRecord
 
   scope :active, -> { where(ended_at: nil) }
   scope :ended, -> { where.not(ended_at: nil) }
+  scope :completed, -> { where.not(decision: nil) }
   scope :for_reviewer, ->(user) { where(reviewer_id: user.id) }
   scope :for_project, ->(project) { where(project_id: project.id) }