feat: Change db query for managers to be more efficient

Author: trillium

backend/controllers/user.controller.js

@@ -44,7 +44,6 @@ UserController.admin_list = async function (req, res) {
   }
 };
 
-// Get list of Users with accessLevel 'admin' or 'superadmin' and also managed projects with GET
 UserController.projectManager_list = async function (req, res) {
   const { headers } = req;
 
@@ -59,30 +58,32 @@ UserController.projectManager_list = async function (req, res) {
 
     const updatedProjectManagers = [];
 
+    const allProjectIds = [
+      ...new Set(
+        projectManagers
+          .map((pm) => pm.managedProjects)
+          .flat()
+          .filter((id) => !!id),
+      ),
+    ];
+
+    const projects = await Project.find({ _id: { $in: allProjectIds } });
+
+    const projectIdToName = {};
+    for (const project of projects) {
+      if (project && project._id && project.name) {
+        projectIdToName[project._id.toString()] = project.name;
+      }
+    }
+
     for (const projectManager of projectManagers) {
       const projectManagerObj = projectManager.toObject();
-
-      /* Due to the way MongoDB searches for non-empty arrays, sometimes an empty array gets passed
-       so we need to check if managedProjects is empty */
       if (projectManagerObj.managedProjects.length === 0) continue;
-
       projectManagerObj.isProjectMember = true;
-      const projectNames = [];
-
-      for (const projectId of projectManagerObj.managedProjects) {
-        // using try-catch block because old user data had invalid strings (aka 'false') for ProjectIds
-        try {
-          const projectDetail = await Project.findById(projectId);
-          if (projectDetail && projectDetail.name) {
-            projectNames.push(projectDetail.name);
-          } else {
-            console.warn('Project detail is null, cannot access name');
-          }
-        } catch (error) {
-          console.warn('Failed to fetch project details for ID:', projectId, error);
-        }
-      }
 
+      const projectNames = projectManagerObj.managedProjects
+        .map((projectId) => projectIdToName[projectId.toString()])
+        .filter(Boolean);
       if (projectNames.length) {
         projectManagerObj.managedProjectNames = projectNames;
         updatedProjectManagers.push(projectManagerObj);
@@ -244,7 +245,6 @@ UserController.signin = function (req, res) {
 };
 
 UserController.verifySignIn = async function (req, res) {
-   
   let token = req.headers['x-access-token'] || req.headers['authorization'];
   if (token.startsWith('Bearer ')) {
     // Remove Bearer from string