2349 docker compose dev env#2529
Conversation
120bb3b to
9770310
Compare
|
Looks like the latest commit broke something in the CI. I'll fix that. |
98819fd to
c1b83c5
Compare
|
I rebased the branch to |
|
We decided in the 2025-06-04 meeting to:
|
c1b83c5 to
43e67ed
Compare
|
I moved the settings back into the |
43e67ed to
3e8dc98
Compare
|
I had some extra "fixes" I didn't intend to push since they're not in the scope of this issue. |
3e8dc98 to
f4d6267
Compare
|
- The file in <root> has git conflicts committed. - The client file also has changes.
f4d6267 to
046b4fe
Compare
|
@fyliu Option 3: Running everything in docker, I get this: Option 4: Running database in docker, app on host machine: It looks like maybe these missing env variables are in the .env.example file, but the start-env.sh script is not looking for them there? I am running Windows and Git Bash, if that matters. |
|
@entrotech I set the scripts to echo every command it runs. Looks like the docker compose command is passing the env files correctly. I haven't tried to use git bash for this. I'll try to fix it to work. Update 2025-06-21: I had trouble setting up npm on my win11 yesterday. I'll keep trying. I did all the work in linux and I generally push windows users to use WSL since it's the easiest way to install all the dependencies: git, npm, python, etc. |
|
@entrotech I was able to set up and run the PR using git bash on windows. I didn't get the missing value errors. I'm wondering if Docker just needs to be updated. It's one thing people say some older Dockers do. I also just removed |
|
@fyliu Now when I try to compose I get: and if I check for any images that might have been built: These are all old, so it doesn't look like any images were built. |
|
I also tried running just the db in docker: This seems to have removed all my other images, but did create one new one: |
|
None of the scripts should magically remove image. I'm guessing, but maybe the newer docker is incompatible with the older one and all the images are now invalid? Ah, I found this SO answer about newer Dockers on Windows using the WSL flag which makes the old images unrecognized by the Docker system. I'm not sure if there's data in the old containers that you want to save. I see another SO answer with steps to migrate images and volumes although I don't understand much after a quick glance. You might try to rebuild the tdm images first with The flyway and sqlserver images are big downloads. |
|
If you don't care about the containers you had, you can clean them up. Here's a list of artifacts you can remove in docker. The last command includes everything. # Omit the -f to see what's being deleted before giving confirmation
# remove build cache
docker buildx prune -f
# remove unused containers
docker container prune -f
# remove dangling images not associated with a container
docker image prune -f
# remove unused images
docker image prune -f -a
# remove all unused containers, images, network, and build cache
docker system prune -fReference used: How to clear Docker cache and free up space on your system |
|
@Tony-Villa @entrotech @fyliu what is the next step for this PR? It looks like there are conflicts to resolve. Is Fang responsible for doing that. Are there any other blockers to approving this? |
ExperimentsInHonesty
left a comment
There was a problem hiding this comment.
@fyliu Tony is able to get this working on his Mac, but John can't get it working on his PC. Given that this issue is supposed to make it easier to work on the code base, the fact that john is having isssues making it work, is concerning. What do you think we should do next?
|
I'm seeing this just now. @entrotech What is failing? Is there any helpful messages in the terminal we can work with? I think you're using git bash on windows and have the code checked out on One thing to note is to run it using the npm script rather than using |
What changes did you make?
docker-composeenvironmentdocker-compose.yml descriptionof the 6 service containersWhy did you make the changes (we will use this info to test)?
Testing
Please note any missing documentation (from link above) that will need to be added.
There's no changes to the existing
dotenvfile. All the new settings are in override files that gets applied.See the documentation for how to run the 4 configurations. They all can be run using the same
npm run env --command and passing in the configuration names.npm run testfrom theserver/directory should still work for the "shared-db" configuration.npm run flyway:migratefromserver/directory should still work for the "shared-db" configuration.Maybe have developers on different platforms try it to find any issues.
Remarks