fix(terms): change LADOT email link to mailto: instead of website (#3082)#3144
Closed
SAY-5 wants to merge 4 commits intohackforla:mainfrom
Closed
fix(terms): change LADOT email link to mailto: instead of website (#3082)#3144SAY-5 wants to merge 4 commits intohackforla:mainfrom
SAY-5 wants to merge 4 commits intohackforla:mainfrom
Conversation
* Add migration to create a login history table * Update delete user spoc to delete loginid references when deleting user * Clean spoc description * Add login history insert stored procedure and relevant services * Add login id index to optimize latest date search * Fix unauthorized route misspelling in Roles component on get accounts * Update select all procedures to get user's last login * Rename lastLogin variable to lastLoginDate to make field type explicit
…ackforla#3122) Code Changes: - Apply a fix to shouldBlock in FaqView.jsx so that it respects admin mode - Add an explicit safeguard inside the component's handleSetFAQ function so that it early-exits when not in edit mode
…ckforla#3082) Closes hackforla#3082. The bottom of the Terms and Conditions page rendered the LADOT contact email as a link, but the `href` pointed to `https://www.lacity.org/` instead of a `mailto:` URI. Clicking the link took the user to a generic city website rather than opening their default email client — the very thing the link text promised. One-line fix: change the href to `mailto:ladot.tdm@lacity.org`. The visible link text was already correct, so users see no change other than the click behavior matching the visible text.
Member
|
Hello, Sai. You do not appear to be a developer onboarded to the Hack for LA TDM Calculator project. If you are interested in joining as a volunteer, you can join by onboarding here: https://www.hackforla.org/join We normally would not accept PRs from non-members, but this one was fairly trivial, so I will, but I had to rebase from your PR to clean up the commit history and only get your actual change to create PR#3160, and replace this PR with the new one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3082.
Summary
The bottom of the Terms and Conditions page renders the LADOT contact email as a link, but the `href` pointed to `https://www.lacity.org/\` instead of a `mailto:` URI. Clicking the link took the user to a generic city website rather than opening their default email client — the very thing the link text promised.
Change
One-line fix in `client/src/components/TermsAndConditions/TermsAndConditionsContent.jsx`:
The visible link text was already correct, so the user sees no change other than the click behavior now matching what the text promises.
Test plan
hrefchanges; surrounding markup, classes, and layout are untouched.Action items mapping (from issue)
mailto:link.