Add Mudassir Hussain to the VRMS project team#7983
Merged
t-will-gillis merged 1 commit intohackforla:gh-pagesfrom Mar 9, 2025
Merged
Add Mudassir Hussain to the VRMS project team#7983t-will-gillis merged 1 commit intohackforla:gh-pagesfrom
t-will-gillis merged 1 commit intohackforla:gh-pagesfrom
Conversation
github-project-automation
bot
moved this to PR Needs review
in P: HfLA Website: Project Board
|
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes. |
github-actions
bot
added
good first issue
Member
|
Review ETA: 5PM March 8, 2025 |
DDVVPP
approved these changes
Mar 7, 2025
Member
There was a problem hiding this comment.
@nchanyal Looks good!
- The pull request is made with the correct branch
- The issue is correctly linked
- Mudassir Hussain has been added to projects/vrms per issue requirements
- Before and after images match my local and prod environments
Minor suggestion for next time: Perhaps add a slightly more descriptive branch name like add-madassir-hussain-to-project-profile-7875
Member
|
Review ETA: EOD 3/7/25 |
lc1715
approved these changes
Mar 8, 2025
Member
lc1715
left a comment
lc1715
left a comment
There was a problem hiding this comment.
Hi @nchanyal, you did an excellent job on your good first issue!
- The PR was done with the correct branch and linked issue
- You added the profile for Mudassir Hussain into the
_projects/vrms.mdfile - The correct changes can be seen in the browser and the source code looks good
github-project-automation
bot
moved this from PR Needs review
to PRs ✅ waiting for merge team
in P: HfLA Website: Project Board
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7875
What changes did you make?
leadershipvariable in the_projects/vrms.mdfileWhy did you make the changes (we will use this info to test)?
CodeQL Alerts
After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.
Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown
Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.
Instructions for resolving CodeQL alerts
If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.
In general, CodeQL alerts should be resolved prior to PR reviews and merging
Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)
Visuals before changes are applied
Visuals after changes are applied