Update & move Danielle Aras' profile for the website project team#7986
Merged
siyunfeng merged 1 commit intohackforla:gh-pagesfrom Mar 13, 2025
Merged
Conversation
github-project-automation
bot
moved this to PR Needs review
in P: HfLA Website: Project Board
|
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes. |
github-actions
bot
added
good first issue
DrAcula27
approved these changes
Mar 10, 2025
Member
DrAcula27
left a comment
DrAcula27
left a comment
There was a problem hiding this comment.
@nchanyal Great job on your Good First Issue! Your code passed the ABC's, including:
- PR is made from the correct branch
- PR links to the correct issue:
- The correct file
_projects/website.mdwas edited - No extra edits were made
- Appearance of the website looks good (Chrome and Firefox)
Approved! 👍
Member
|
Availability: Monday - Friday, 10:00 AM to 4:00 PM JST |
rogerioduenas
approved these changes
Mar 11, 2025
Member
rogerioduenas
left a comment
rogerioduenas
left a comment
There was a problem hiding this comment.
Hi @nchanyal!
Great job with this pull request!
- The branching was done correctly.
- Issue number was listed.
- The PR title is descriptive of the changes.
- Changes were made correctly in the code.
- Changes appear correctly on the site
_projects/website.mdwas edited correctly.- Relevant images were included to show visual changes.
- The PR request clearly states what was updated.
Again, great work, and thanks for taking the time to contribute to the website. Congratulations on your good first issue!
github-project-automation
bot
moved this from PR Needs review
to PRs ✅ waiting for merge team
in P: HfLA Website: Project Board
31 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7938
What changes did you make?
leadershipvariable for Danielle Aras' profile in_projects/website.mdleadershipvariable so that it is with the other "Developer Co-Lead" profileWhy did you make the changes (we will use this info to test)?
CodeQL Alerts
After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.
Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown
Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.
Instructions for resolving CodeQL alerts
If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.
In general, CodeQL alerts should be resolved prior to PR reviews and merging
Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)
Visuals before changes are applied
Visuals after changes are applied