Updated Docker V1 Syntax#8335
Conversation
|
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes. Note that CONTRIBUTING.md cannot previewed locally; rather it should be previewed at this URL: |
|
Availability: 5-7 PM pacific |
myronchen-git
left a comment
There was a problem hiding this comment.
Hi Edward. Thank you for working on this issue.
Done correctly
- The merge from and to branches are correct.
- The originating issue is linked correctly.
- You've assigned yourself and set the status correctly in the originating issue.
Changes that need to be made
- Please remove
_projects/civic-tech-jobs.mdfrom your pull request. Even though it has only whitespace changes, it is not related to the issue. - In the originating issue, you forgot to check off the last action item.
Optional recommendations
- I don't think the screenshots are really necessary. Screenshots are used to help see visual changes that can not be shown through the Files changed tab of pull requests.
|
Availability: after 7pm on weekdays |
caz002
left a comment
There was a problem hiding this comment.
Thank you for working on this issue @devxed43 !
Things Done Well
- PR description accurately describes changes and why they were made
- Description includes link to test out/view changes
- Changes on branch match those requested by issue
- PR does not trigger any Code QL alerts
Changes to Make
- I agree with myronchen-git to remove edits to
_projects/civic-tech-jobs.md. Even though the changes only affect the formatting, the issue instructions did not mention to change that file.
There was a problem hiding this comment.
It seems you accidentally deleted the file _projects/civic-tech-jobs.md from your branch, instead of restoring it back to its original form. If done correctly, the "Files Changed" tab on the pull request should only be 1 file, or CONTRIBUTING.md. Let me know if you need help with restoring the _projects/civic-tech-jobs.md file.
I believe i've restored the _projects/civic-tech-jobs.md file back to its original form. can you verify please? 😊 |
There was a problem hiding this comment.
Done correctly
- Good job on figuring out how to restore
civic-tech-jobs.md. Only the relevant files are included in your pull request now.
Changes that need to be made
- In the screenshot section, the PR should state that there are no visual changes instead of being blank. There is a comment in the PR description, when you go edit it, that tells you what to put.
caz002
left a comment
There was a problem hiding this comment.
Looks great! Thank you for making all of the requested changes.
|
@devxed43 Thank you for your fantastic contribution! I’ve merged your issue. |
Thank you! It was a great learning experience to edit my first documentation file. |
Fixes #8183
What changes did you make?
Why did you make the changes (we will use this info to test)?
CodeQL Alerts
After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.
Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown
Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.
Instructions for resolving CodeQL alerts
If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.
In general, CodeQL alerts should be resolved prior to PR reviews and merging
Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)