Skip to content

Updated Docker V1 Syntax#8335

Merged
dvernon5 merged 7 commits intohackforla:gh-pagesfrom
devxed43:update-docker-md-8183
Sep 26, 2025
Merged

Updated Docker V1 Syntax#8335
dvernon5 merged 7 commits intohackforla:gh-pagesfrom
devxed43:update-docker-md-8183

Conversation

@devxed43
Copy link
Copy Markdown
Member

@devxed43 devxed43 commented Sep 20, 2025

Fixes #8183

What changes did you make?

  • Replaced 9 instances of "docker-compose" in CONTRIBUTING.md

Why did you make the changes (we will use this info to test)?

CodeQL Alerts

After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.

Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown

Screenshot 2024-10-28 154514

Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.

  • I have checked this PR for CodeQL alerts and none were found.
  • I found CodeQL alert(s), and (select one):
    • I have resolved the CodeQL alert(s) as noted
    • I believe the CodeQL alert(s) is a false positive (Merge Team will evaluate)
    • I have followed the Instructions below, but I am still stuck (Merge Team will evaluate)
Instructions for resolving CodeQL alerts

If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.

In general, CodeQL alerts should be resolved prior to PR reviews and merging

Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)

  • No visual changes to the website

@github-actions
Copy link
Copy Markdown

Want to review this pull request? Take a look at this documentation for a step by step guide!


From your project repository, check out a new branch and test the changes.

git checkout -b devxed43-update-docker-md-8183 gh-pages
git pull https://github.com/devxed43/website.git update-docker-md-8183

Note that CONTRIBUTING.md cannot previewed locally; rather it should be previewed at this URL:

https://github.com/devxed43/website/blob/update-docker-md-8183/CONTRIBUTING.md  

@github-actions github-actions Bot added role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers Feature: Onboarding/Contributing.md Complexity: Small Take this type of issues after the successful merge of your second good first issue size: 0.5pt Can be done in 3 hours or less labels Sep 20, 2025
@myronchen-git
Copy link
Copy Markdown
Member

Availability: 5-7 PM pacific
ETA: end of 9-21

Copy link
Copy Markdown
Member

@myronchen-git myronchen-git left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Edward. Thank you for working on this issue.


Done correctly

  • The merge from and to branches are correct.
  • The originating issue is linked correctly.
  • You've assigned yourself and set the status correctly in the originating issue.

Changes that need to be made

  • Please remove _projects/civic-tech-jobs.md from your pull request. Even though it has only whitespace changes, it is not related to the issue.
  • In the originating issue, you forgot to check off the last action item.

Optional recommendations

  • I don't think the screenshots are really necessary. Screenshots are used to help see visual changes that can not be shown through the Files changed tab of pull requests.

@github-project-automation github-project-automation Bot moved this from PR Needs review to PRs being reviewed in P: HfLA Website: Project Board Sep 21, 2025
@caz002 caz002 self-requested a review September 21, 2025 00:16
@caz002
Copy link
Copy Markdown
Member

caz002 commented Sep 21, 2025

Availability: after 7pm on weekdays
ETA: 9/20

Copy link
Copy Markdown
Member

@caz002 caz002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for working on this issue @devxed43 !

Things Done Well

  • PR description accurately describes changes and why they were made
  • Description includes link to test out/view changes
  • Changes on branch match those requested by issue
  • PR does not trigger any Code QL alerts

Changes to Make

  • I agree with myronchen-git to remove edits to _projects/civic-tech-jobs.md. Even though the changes only affect the formatting, the issue instructions did not mention to change that file.

@devxed43 devxed43 requested review from caz002 and myronchen-git and removed request for t-will-gillis September 21, 2025 16:51
Copy link
Copy Markdown
Member

@caz002 caz002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems you accidentally deleted the file _projects/civic-tech-jobs.md from your branch, instead of restoring it back to its original form. If done correctly, the "Files Changed" tab on the pull request should only be 1 file, or CONTRIBUTING.md. Let me know if you need help with restoring the _projects/civic-tech-jobs.md file.

@devxed43
Copy link
Copy Markdown
Member Author

It seems you accidentally deleted the file _projects/civic-tech-jobs.md from your branch, instead of restoring it back to its original form. If done correctly, the "Files Changed" tab on the pull request should only be 1 file, or CONTRIBUTING.md. Let me know if you need help with restoring the _projects/civic-tech-jobs.md file.

I believe i've restored the _projects/civic-tech-jobs.md file back to its original form. can you verify please? 😊

Copy link
Copy Markdown
Member

@myronchen-git myronchen-git left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done correctly

  • Good job on figuring out how to restore civic-tech-jobs.md. Only the relevant files are included in your pull request now.

Changes that need to be made

  • In the screenshot section, the PR should state that there are no visual changes instead of being blank. There is a comment in the PR description, when you go edit it, that tells you what to put.

@caz002 caz002 self-requested a review September 24, 2025 02:15
Copy link
Copy Markdown
Member

@caz002 caz002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thank you for making all of the requested changes.

@github-project-automation github-project-automation Bot moved this from PRs being reviewed to PRs ✅ waiting for merge team in P: HfLA Website: Project Board Sep 24, 2025
@dvernon5 dvernon5 merged commit 6f3cb4e into hackforla:gh-pages Sep 26, 2025
7 of 10 checks passed
@dvernon5
Copy link
Copy Markdown
Member

@devxed43 Thank you for your fantastic contribution! I’ve merged your issue.

@devxed43
Copy link
Copy Markdown
Member Author

@devxed43 Thank you for your fantastic contribution! I’ve merged your issue.

Thank you! It was a great learning experience to edit my first documentation file.

@devxed43 devxed43 deleted the update-docker-md-8183 branch September 26, 2025 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Complexity: Small Take this type of issues after the successful merge of your second good first issue Feature: Onboarding/Contributing.md role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less

Projects

Development

Successfully merging this pull request may close these issues.

Update CONTRIBUTING.md Docker Compose Syntax to V2

4 participants