Skip to content

Remove Aditya Soni from Guides Team profile#8354

Merged
t-will-gillis merged 1 commit intohackforla:gh-pagesfrom
Mykola-Lopushenko:remove-aditya-soni
Oct 2, 2025
Merged

Remove Aditya Soni from Guides Team profile#8354
t-will-gillis merged 1 commit intohackforla:gh-pagesfrom
Mykola-Lopushenko:remove-aditya-soni

Conversation

@Mykola-Lopushenko
Copy link
Copy Markdown
Member

Fixes #8113

What changes did you make?

  • Edited _projects/guides-team.md
  • Removed the leadership field about Aditya Soni

Why did you make the changes (we will use this info to test)?

  • Keep the Guides Team page accurate and up to date
  • Verified locally via Docker that the profile no longer appears under Current Project Team

CodeQL Alerts

After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.

Before changes are applied Screenshot before PR
After changes are applied Screenshot after PR

Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.

  • I have checked this PR for CodeQL alerts and none were found.
  • I found CodeQL alert(s), and (select one):
    • I have resolved the CodeQL alert(s) as noted
    • I believe the CodeQL alert(s) is a false positive (Merge Team will evaluate)
    • I have followed the Instructions below, but I am still stuck (Merge Team will evaluate)

@github-actions
Copy link
Copy Markdown

Want to review this pull request? Take a look at this documentation for a step by step guide!


From your project repository, check out a new branch and test the changes.

git checkout -b Mykola-Lopushenko-remove-aditya-soni gh-pages
git pull https://github.com/Mykola-Lopushenko/website.git remove-aditya-soni

@github-actions github-actions Bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) time sensitive Needs to be worked on by a particular timeframe size: 0.25pt Can be done in 0.5 to 1.5 hours labels Sep 30, 2025
@lastCoyotes lastCoyotes self-requested a review September 30, 2025 16:17
@lastCoyotes
Copy link
Copy Markdown
Member

ETA: by 10 AM PDT
Availability 9-7pm PDT Mon-Thurs

@Hiroeme
Copy link
Copy Markdown
Member

Hiroeme commented Sep 30, 2025

Review ETA: 11AM PDT
Availability: 6-8 PM Weekdays

Copy link
Copy Markdown
Member

@Hiroeme Hiroeme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank for contributing @Mykola-Lopushenko !! Very cool beans.

Things done well

  • Issue has been correctly linked
  • Pull Request named properly
  • Reasons for the changes are good
  • CodeQL displayed no errors
  • Before and after visuals are good

Changes to be made

  • I believe your branch name remove-aditya-soni is missing the related issue number. If you need help, you can take a look at the example from Contributing.MD.

Copy link
Copy Markdown
Member

@lastCoyotes lastCoyotes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve this PR!

Changes made are made clear in the images provided, follows the issue, and states why this solves the issue.

Things to note for next time, though: include the PR number in the branch name "remove-aditya-soni-8354"
Otherwise, no other issues in the code to catch!

@Mykola-Lopushenko
Copy link
Copy Markdown
Member Author

Thank you for the review and approval! I’ll keep your notes in mind for future contributions.

@Mykola-Lopushenko
Copy link
Copy Markdown
Member Author

Thank for contributing @Mykola-Lopushenko !! Very cool beans.

Things done well

  • Issue has been correctly linked
  • Pull Request named properly
  • Reasons for the changes are good
  • CodeQL displayed no errors
  • Before and after visuals are good

Changes to be made

  • I believe your branch name remove-aditya-soni is missing the related issue number. If you need help, you can take a look at the example from Contributing.MD.

Thanks for pointing this out! I’ll make sure to include the issue number in the branch name for my next PR.

Copy link
Copy Markdown
Member

@Hiroeme Hiroeme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I realize PR doc didn't specify issue number in the branch name, but for next time, it would be nice to have. I'll approve!

@github-project-automation github-project-automation Bot moved this from PR Needs review to PRs ✅ waiting for merge team in P: HfLA Website: Project Board Oct 1, 2025
@t-will-gillis t-will-gillis merged commit 799770f into hackforla:gh-pages Oct 2, 2025
8 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

good first issue Good for newcomers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours time sensitive Needs to be worked on by a particular timeframe

Projects

Development

Successfully merging this pull request may close these issues.

Update Project Profile: Guides Team - Remove Aditya Soni

4 participants