Remove Aditya Soni from Guides Team profile#8354
Remove Aditya Soni from Guides Team profile#8354t-will-gillis merged 1 commit intohackforla:gh-pagesfrom
Conversation
|
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes. |
|
ETA: by 10 AM PDT |
|
Review ETA: 11AM PDT |
There was a problem hiding this comment.
Thank for contributing @Mykola-Lopushenko !! Very cool beans.
Things done well
- Issue has been correctly linked
- Pull Request named properly
- Reasons for the changes are good
- CodeQL displayed no errors
- Before and after visuals are good
Changes to be made
- I believe your branch name
remove-aditya-soniis missing the related issue number. If you need help, you can take a look at the example from Contributing.MD.
lastCoyotes
left a comment
There was a problem hiding this comment.
I approve this PR!
Changes made are made clear in the images provided, follows the issue, and states why this solves the issue.
Things to note for next time, though: include the PR number in the branch name "remove-aditya-soni-8354"
Otherwise, no other issues in the code to catch!
|
Thank you for the review and approval! I’ll keep your notes in mind for future contributions. |
Thanks for pointing this out! I’ll make sure to include the issue number in the branch name for my next PR. |
Hiroeme
left a comment
There was a problem hiding this comment.
I realize PR doc didn't specify issue number in the branch name, but for next time, it would be nice to have. I'll approve!
Fixes #8113
What changes did you make?
Why did you make the changes (we will use this info to test)?
CodeQL Alerts
After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.
Before changes are applied
After changes are applied
Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.