Conversation
|
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes. |
DDVVPP
left a comment
There was a problem hiding this comment.
Great work @gabbyjimenez
- The PR title and branch name are clear
- The changes are present in the browser
- There is a linked issue attached
Just a few edits if possible:
- The
visuals before & after changeslinks are broken for me - would you mind double checking those and updating? - It would be nice to see all of the action items in the original linked issue checked off to indicate that you've completed all of the tasks
Thank you!
|
Availability: after 11am (pacific) |
DDVVPP
left a comment
There was a problem hiding this comment.
Thanks for the changes @gabbyjimenez !
kdaca19xx
left a comment
There was a problem hiding this comment.
Thank you, gabbyjimenez!
Things Done Well
-
The pull request was done with the correct branch.
-
There's a linked issue. I read/understood it.
-
You ticked the action items on the original linked issue as DDVVPP suggested.
-
Your deletion in the Files Changed tab looks good.
-
You fixed the look of the text and before/after visuals as DDVVPP suggested, and I can see the deletion in Docker.
Suggestions
- none
I'd like to approve this PR.
Fixes #8119
What changes did you make?
Why did you make the changes (we will use this info to test)?
CodeQL Alerts
After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.
Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown
Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.
Instructions for resolving CodeQL alerts
If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.
In general, CodeQL alerts should be resolved prior to PR reviews and merging
Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)
Visuals before changes are applied
Visuals after changes are applied