Updated wins.js so Wins page uses icon-github.svg#8379
Merged
daras-cu merged 4 commits intohackforla:gh-pagesfrom Oct 28, 2025
Merged
Updated wins.js so Wins page uses icon-github.svg#8379daras-cu merged 4 commits intohackforla:gh-pagesfrom
daras-cu merged 4 commits intohackforla:gh-pagesfrom
Conversation
…e github icon with file type of svg.
…to the github icon saved within assets: /asstes/images/wins-page/icon-github-small.svg. Also Removed the literal definition of GITHUB_ICON where the path to this icon svg which is being replaced. Modified line where the alt property was defined for the img which used to store the svg. To comply with WCAG, we instead add the description to the aria-label using the setAttribute method.
…ppearance of linkedin-icon class elements. Because the github-icon svg is rendered inline, the viewBox inherits a larger sizing from the source file than the Linkedin icon. Inspecting the linked-in image revealed a base size of 32px x 32px. To replicate this sizing, we set github-icon div width and height to 32px by 32px and made a rule for the svg to fill the container width and height by 100%.
|
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes. |
Member
|
Review ETA: 10/22/25 |
lc1715
approved these changes
Oct 23, 2025
Member
lc1715
left a comment
There was a problem hiding this comment.
@santi-jose Great job working on this issue!
- The PR contains the correct branch and linked issue
- The code that renders the Github icon has been updated and the styling remains unchanged
- There were no CodeQL Alerts detected
Member
Author
|
Thanks for the review!🙏 @lc1715 |
Member
|
Sure, Thanks for working on this issue! 🎉 |
daras-cu
approved these changes
Oct 28, 2025
Member
daras-cu
left a comment
There was a problem hiding this comment.
Hi @santi-jose, great job on this issue.
- Your PR is set up correctly with the right branches and a thorough explanation of changes
- You made the required code changes
- The Wins page is unchanged when testing, with the updated GitHub icon svg displaying correctly at the right size
- You added the
aria-labelattribute to ensure accessibility
Thank you for working on this issue!
Member
Author
|
Thanks for the review! @daras-cu |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6911
What changes did you make?
_includes/wins-page/wins-card-template.html/wins-card-template.html, replaced current reference togithub-iconusing theimgelement, with new inline expression renderinggithub-iconwithin adivelement.Specifically replaced:
<a target="_blank" class="wins-card-github-icon"><img class="github-icon" alt="" /></a>with:
makeCardsfunction inassets/js/wins.js, removed theimgelement source definition since we replaced theimgelement.GITHUB_ICONwhich set the path to the svg used to define the source for the previously used img element.aria-labelattribute and definition to thegithub-icon's svg div. Used the previous definition of thealtattribute of theimgelement for thearia-labelof thegithub-iconsvgdiv._sass/components/_wins-page.scssto ensure the styling of the GitHub icon remained unchanged after replacing the source. Set the github-icon element in_wins-page.scssheightandwidthto 32px. Also set themax-widthto 100% to mimic the behavior of the LinkedIn icon. Set the SVGwidthandheightproperties nested within thegithub-iconelementdivto 100% so they would adhere to the sizing of the parent element. In this case thegithub-icondivis the parent element. Therefore the SVG should render to be 32x32 px.Why did you make the changes (we will use this info to test)?
CodeQL Alerts
After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.
Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown
Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.
Instructions for resolving CodeQL alerts
If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.
In general, CodeQL alerts should be resolved prior to PR reviews and merging
Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)