Added github handle for Leroy Tung#8416
Merged
daras-cu merged 1 commit intohackforla:gh-pagesfrom Nov 13, 2025
Merged
Conversation
github-project-automation
Bot
moved this to PR Needs review
in P: HfLA Website: Project Board
34 tasks
|
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes. |
github-actions
Bot
added
good first issue
Member
|
Review ETA: 4 PM PST 11/11/25 |
aymeviviana
approved these changes
Nov 11, 2025
Member
aymeviviana
left a comment
aymeviviana
left a comment
There was a problem hiding this comment.
Thank you so much for your excellent work on this PR, @ldaws003 !
Done Correctly:
- The Pull Request uses the correct branch
- The linked issue is present and correctly formatted
- The CodeQL Alerts section is correctly completed
- Code update is applicable and clean
- Change looks consistent across multiple screen sizes
Suggestions:
- For future PR’s you can delete the note at the top of the post that ends with “Delete this message if you joined this team via onboarding.”
- A bit more context in the “Why did you make the changes” section would be helpful. Perhaps something like “This change is part of a rollout that will replace GitHub info in leadership team profiles with a single variable.”
Member
|
Review ETA 5pm 11/11/25 |
cadenramey
requested changes
Nov 11, 2025
Member
cadenramey
left a comment
cadenramey
left a comment
There was a problem hiding this comment.
Hey @ldaws003 great job on the PR!
- PR done with the correct branch
- Linked issue correctly
- Correctly made no visual changes to site
- Correct file changed
Needs fixing:
Basically same as the suggestions made by @aymeviviana
- Please delete the top paragraph on the PR - start with Fixes #7333
- Please elaborate on why you made the changes you did (ie. why are we adding the github-handle variable?). This is just for clarity sake especially when you move to more complex issues, this section will become much more important.
github-project-automation
Bot
moved this from PR Needs review
to PRs being reviewed
in P: HfLA Website: Project Board
cadenramey
approved these changes
Nov 12, 2025
Member
cadenramey
left a comment
cadenramey
left a comment
There was a problem hiding this comment.
Good job on the changes - everything looks great! Will go ahead and approve the request.
github-project-automation
Bot
moved this from PRs being reviewed
to PRs ✅ waiting for merge team
in P: HfLA Website: Project Board
31 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7333
What changes did you make?
github-handle:under Leroy Tung's entry in _projects/youthjusticenav.mdWhy did you make the changes (we will use this info to test)?
githubandpicturevariables withgithub-handleCodeQL Alerts
After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.
Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown
Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.
Instructions for resolving CodeQL alerts
If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.
In general, CodeQL alerts should be resolved prior to PR reviews and merging
Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)