Added Member To Hack4LA Website Team Page#8463
Conversation
|
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes. |
|
Review ETA: 6 PM 1/18/22 |
abinetabate1
left a comment
There was a problem hiding this comment.
Looks good.
Minor Nit Pick --> Please check CodeQL Alerts checkbox (i.e. "I have checked this PR for CodeQL alerts and none were found.")
Done, thank you for the review :) |
santiseccovidal
left a comment
There was a problem hiding this comment.
Hi @KSamra everything looks good. Code changes, branches and screenshots. As issues become more complex the What and Why sections become more important for reviewers, good job there too.
|
Hi @KSamra, good work on this issue. For the future, you should make your PR title and description a little more specific by mentioning the specific member you added. There are often issues to add or remove team members so it helps to differentiate them. |
Fixes #8329
What changes did you make?
Why did you make the changes (we will use this info to test)?
CodeQL Alerts
After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.
Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown
Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.
Instructions for resolving CodeQL alerts
If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.
In general, CodeQL alerts should be resolved prior to PR reviews and merging
Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)
Visuals before changes are applied
Visuals after changes are applied