Changed Agenda reference numbers for team schedule#8502
Changed Agenda reference numbers for team schedule#8502ryanfkeller merged 1 commit intohackforla:gh-pagesfrom
Conversation
|
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes. |
|
Since there is now a |
@myronchen-git - what do you mean when you say "import". Are you suggesting some kind of automated mechanism...like a github action to take the data from "static-issue-nums.json" and "update create-new-issue.js". Or maybe you want to update the js code to pull from the .json. Would like to understand exactly what you are proposing. Perhaps a different issue needs to be created for your proposal. This approach seems like a good quick fix for now and we can follow up with your suggestion later. Just a thought. |
It's retrieving the data from the JSON using the keyword |
Thanks for explaining. I learned something. That said, I'm going to defer to @cadenramey and @t-will-gillis as to how we move forward. At a minimum, I would suggest that the existing issue get updated to reflect the new approach. |
|
I'm agreed with both @myronchen-git and @abinetabate1 -- I think that Myron's suggestion of importing the issue number is the right call, but also that #8451 would need to be updated to account for that (just so this PR doesn't wind up doing something different than the issue requires). I'll bring it up in the meeting tonight. Thanks to you both for having a productive discussion! |
|
Got feedback from @daras-cu , we'll go ahead and review/merge this issues as is and add a new ER to implement Myron's suggestion since we SHOULD do that suggestion, but it's a bit out of scope for this issue. |
ryanfkeller
left a comment
There was a problem hiding this comment.
Looks good, thanks for making these updates @cadenramey!
Fixes #8451
What changes did you make?
Why did you make the changes (we will use this info to test)?
CodeQL Alerts
After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.
Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown
Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.
Instructions for resolving CodeQL alerts
If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.
In general, CodeQL alerts should be resolved prior to PR reviews and merging
Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)