Skip to content

Changed Agenda reference numbers for team schedule#8502

Merged
ryanfkeller merged 1 commit intohackforla:gh-pagesfrom
cadenramey:update-agenda-issue-num-8451
Feb 11, 2026
Merged

Changed Agenda reference numbers for team schedule#8502
ryanfkeller merged 1 commit intohackforla:gh-pagesfrom
cadenramey:update-agenda-issue-num-8451

Conversation

@cadenramey
Copy link
Copy Markdown
Member

Fixes #8451

What changes did you make?

  • I updated the Agenda reference numbers in two files pertaining to the 2026 schedule

Why did you make the changes (we will use this info to test)?

  • I made these changes because we're in a new year. The new number now sends notifications reflecting this for Monday Dev/PM meetings.

CodeQL Alerts

After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.

Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown

Screenshot 2024-10-28 154514

Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.

  • I have checked this PR for CodeQL alerts and none were found.
  • I found CodeQL alert(s), and (select one):
    • I have resolved the CodeQL alert(s) as noted
    • I believe the CodeQL alert(s) is a false positive (Merge Team will evaluate)
    • I have followed the Instructions below, but I am still stuck (Merge Team will evaluate)
Instructions for resolving CodeQL alerts

If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.

In general, CodeQL alerts should be resolved prior to PR reviews and merging

Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)

  • No visual changes to the website

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Feb 4, 2026

Want to review this pull request? Take a look at this documentation for a step by step guide!


From your project repository, check out a new branch and test the changes.

git checkout -b cadenramey-update-agenda-issue-num-8451 gh-pages
git pull https://github.com/cadenramey/website.git update-agenda-issue-num-8451

@github-actions github-actions Bot added role: back end/devOps Tasks for back-end developers time sensitive Needs to be worked on by a particular timeframe Complexity: Small Take this type of issues after the successful merge of your second good first issue size: 1pt Can be done in 4-6 hours feature: agenda labels Feb 4, 2026
@cadenramey cadenramey changed the title Changes agenda number in both files Changed Agenda reference numbers for team schedule Feb 4, 2026
@myronchen-git myronchen-git self-requested a review February 6, 2026 06:22
@myronchen-git
Copy link
Copy Markdown
Member

Since there is now a github-actions/utils/_data/static-issue-nums.json that stores the agenda issue number, should we import the issue number into github-actions/trigger-schedule/list-inactive-members/create-new-issue.js, instead of changing the variable in that every year? This would also help reduce adding trivial commits to the file.
@t-will-gillis
@cadenramey

Copy link
Copy Markdown
Member

@abinetabate1 abinetabate1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good. Thank you!

@abinetabate1
Copy link
Copy Markdown
Member

Since there is now a github-actions/utils/_data/static-issue-nums.json that stores the agenda issue number, should we import the issue number into github-actions/trigger-schedule/list-inactive-members/create-new-issue.js, instead of changing the variable in that every year? This would also help reduce adding trivial commits to the file. @t-will-gillis @cadenramey

@myronchen-git - what do you mean when you say "import". Are you suggesting some kind of automated mechanism...like a github action to take the data from "static-issue-nums.json" and "update create-new-issue.js". Or maybe you want to update the js code to pull from the .json. Would like to understand exactly what you are proposing. Perhaps a different issue needs to be created for your proposal. This approach seems like a good quick fix for now and we can follow up with your suggestion later. Just a thought.

@hackforla hackforla deleted a comment from abinetabate1 Feb 7, 2026
@myronchen-git
Copy link
Copy Markdown
Member

Since there is now a github-actions/utils/_data/static-issue-nums.json that stores the agenda issue number, should we import the issue number into github-actions/trigger-schedule/list-inactive-members/create-new-issue.js, instead of changing the variable in that every year? This would also help reduce adding trivial commits to the file. @t-will-gillis @cadenramey

@myronchen-git - what do you mean when you say "import". Are you suggesting some kind of automated mechanism...like a github action to take the data from "static-issue-nums.json" and "update create-new-issue.js". Or maybe you want to update the js code to pull from the .json. Would like to understand exactly what you are proposing. Perhaps a different issue needs to be created for your proposal. This approach seems like a good quick fix for now and we can follow up with your suggestion later. Just a thought.

It's retrieving the data from the JSON using the keyword require. This also does not require a separate issue, as it is a small task, like changing a variable declaration from using var to let.

@abinetabate1
Copy link
Copy Markdown
Member

Since there is now a github-actions/utils/_data/static-issue-nums.json that stores the agenda issue number, should we import the issue number into github-actions/trigger-schedule/list-inactive-members/create-new-issue.js, instead of changing the variable in that every year? This would also help reduce adding trivial commits to the file. @t-will-gillis @cadenramey

@myronchen-git - what do you mean when you say "import". Are you suggesting some kind of automated mechanism...like a github action to take the data from "static-issue-nums.json" and "update create-new-issue.js". Or maybe you want to update the js code to pull from the .json. Would like to understand exactly what you are proposing. Perhaps a different issue needs to be created for your proposal. This approach seems like a good quick fix for now and we can follow up with your suggestion later. Just a thought.

It's retrieving the data from the JSON using the keyword require. This also does not require a separate issue, as it is a small task, like changing a variable declaration from using var to let.

Since there is now a github-actions/utils/_data/static-issue-nums.json that stores the agenda issue number, should we import the issue number into github-actions/trigger-schedule/list-inactive-members/create-new-issue.js, instead of changing the variable in that every year? This would also help reduce adding trivial commits to the file. @t-will-gillis @cadenramey

@myronchen-git - what do you mean when you say "import". Are you suggesting some kind of automated mechanism...like a github action to take the data from "static-issue-nums.json" and "update create-new-issue.js". Or maybe you want to update the js code to pull from the .json. Would like to understand exactly what you are proposing. Perhaps a different issue needs to be created for your proposal. This approach seems like a good quick fix for now and we can follow up with your suggestion later. Just a thought.

It's retrieving the data from the JSON using the keyword require. This also does not require a separate issue, as it is a small task, like changing a variable declaration from using var to let.

Thanks for explaining. I learned something. That said, I'm going to defer to @cadenramey and @t-will-gillis as to how we move forward. At a minimum, I would suggest that the existing issue get updated to reflect the new approach.

@ryanfkeller
Copy link
Copy Markdown
Member

I'm agreed with both @myronchen-git and @abinetabate1 -- I think that Myron's suggestion of importing the issue number is the right call, but also that #8451 would need to be updated to account for that (just so this PR doesn't wind up doing something different than the issue requires). I'll bring it up in the meeting tonight. Thanks to you both for having a productive discussion!

@ryanfkeller
Copy link
Copy Markdown
Member

Got feedback from @daras-cu , we'll go ahead and review/merge this issues as is and add a new ER to implement Myron's suggestion since we SHOULD do that suggestion, but it's a bit out of scope for this issue.

Copy link
Copy Markdown
Member

@ryanfkeller ryanfkeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for making these updates @cadenramey!

@github-project-automation github-project-automation Bot moved this from PR Needs review to PRs ✅ waiting for merge team in P: HfLA Website: Project Board Feb 11, 2026
@ryanfkeller ryanfkeller merged commit b007300 into hackforla:gh-pages Feb 11, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Complexity: Small Take this type of issues after the successful merge of your second good first issue feature: agenda role: back end/devOps Tasks for back-end developers size: 1pt Can be done in 4-6 hours time sensitive Needs to be worked on by a particular timeframe

Projects

Development

Successfully merging this pull request may close these issues.

Update agenda issue number in two locations

4 participants