HCK-12924: fix getting table columns meta-info without "select" permission#159
Merged
Conversation
Vitalii4as
approved these changes
Sep 30, 2025
| LEFT JOIN pg_catalog.pg_description AS pg_description ON (pg_description.objsubid=pg_attribute.attnum | ||
| AND pg_description.objoid = pg_attribute.attrelid) | ||
| WHERE pg_attribute.attrelid = $1;`, | ||
| GET_TABLE_COLUMNS_FROM_CATALOG: ` |
Contributor
There was a problem hiding this comment.
It looks like this one is from the view select statement, could you please add a comment leading to the original view. Like it is done in GET_TRIGGERS
-- This is information_schema.triggers view but without permitions
Contributor
Author
There was a problem hiding this comment.
Yes, correct. I have a comment about that in the place where this query is used.
Added one more here, thanks.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Technical details
In the RE, we currently use the
information_schema.columnssystem view to retrieve table columns. However, this requires at leastSELECTpermissions on the target table.An alternative is to query
pg_*system catalogs directly. While the data is spread across multiple tables and type-related values can differ slightly, this approach works even withoutSELECTpermissions.This PR introduces a fallback query that retrieves table columns from the system catalogs when
information_schema.columnsreturns no results (likely due to insufficient permissions). Implementing this required composing a complex query with several joins and mappings to match the output ofinformation_schema.columns.Additionally:
information_schema.columns....