Add license validator for HACS action#5219
Open
Copilot wants to merge 10 commits into
Open
Conversation
Adds a new validator that checks repositories have a valid, SPDX-recognized license. Repositories with no license or an unrecognized license (key: "other") will fail validation. Forks are skipped (allow_fork = False). Agent-Logs-Url: https://github.com/hacs/integration/sessions/12156256-5db1-4375-a92c-a55c0bc68168 Co-authored-by: ludeeus <15093472+ludeeus@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
ludeeus
April 14, 2026 08:31
View session
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new repository validator to the HACS GitHub Action that enforces presence of a GitHub-detected, recognized license, along with unit tests covering the expected pass/fail cases.
Changes:
- Introduces
custom_components/hacs/validate/license.pyvalidator that fails when the GitHub API reports no license or an unrecognized license (key == "other"). - Adds tests for the validator covering: missing license, unrecognized license, and a valid SPDX license.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| custom_components/hacs/validate/license.py | New action validator that checks repository_object.attributes["license"] and fails for missing/unrecognized licenses. |
| tests/validate/test_repository_license_check.py | New tests validating failure/success behavior for the new license validator. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ludeeus
reviewed
May 20, 2026
Agent-Logs-Url: https://github.com/hacs/integration/sessions/a6356dfc-1e6a-454c-aaae-5ee2fa70418f Co-authored-by: ludeeus <15093472+ludeeus@users.noreply.github.com>
Agent-Logs-Url: https://github.com/hacs/integration/sessions/a6356dfc-1e6a-454c-aaae-5ee2fa70418f Co-authored-by: ludeeus <15093472+ludeeus@users.noreply.github.com>
Author
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
ludeeus
reviewed
May 20, 2026
ludeeus
reviewed
May 20, 2026
Agent-Logs-Url: https://github.com/hacs/integration/sessions/a3797fd4-0904-404c-ab3a-c9aa9fe971ff Co-authored-by: ludeeus <15093472+ludeeus@users.noreply.github.com>
ludeeus
reviewed
May 20, 2026
Agent-Logs-Url: https://github.com/hacs/integration/sessions/f4b54bf9-d81d-401f-a6f6-cf72c96c98b7 Co-authored-by: ludeeus <15093472+ludeeus@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new license validation check for repositories, ensuring that only repositories with recognized open source licenses pass validation.
Docs: hacs/documentation#687