Skip to content

Use authenticated brands proxy for update entity pictures #5228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
manuveli wants to merge 1 commit into
base: main
Choose a base branch
from
+44 −44
Open

Use authenticated brands proxy for update entity pictures #5228

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion custom_components/hacs/update.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ def entity_picture(self) -> str | None:
):
return None

return f"https://brands.home-assistant.io/_/{self.repository.data.domain}/icon.png"
return f"/api/brands/integration/{self.repository.data.domain}/icon.png"

async def async_install(self, version: str | None, backup: bool, **kwargs: Any) -> None:
"""Install an update."""
Expand Down
2 changes: 1 addition & 1 deletion tests/snapshots/hacs-test-org/appdaemon-basic/test_discard_invalid_repo_data.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@
"area_id": null,
"attributes": {
"auto_update": false,
"entity_picture": "https://brands.home-assistant.io/_/hacs/icon.png",
"entity_picture": "/api/brands/integration/hacs/icon.png",
"friendly_name": "HACS update",
"in_progress": false,
"installed_version": "0.0.0",
Expand Down
2 changes: 1 addition & 1 deletion tests/snapshots/hacs-test-org/appdaemon-basic/test_download_repository.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@
"area_id": null,
"attributes": {
"auto_update": false,
"entity_picture": "https://brands.home-assistant.io/_/hacs/icon.png",
"entity_picture": "/api/brands/integration/hacs/icon.png",
"friendly_name": "HACS update",
"in_progress": false,
"installed_version": "0.0.0",
Expand Down
2 changes: 1 addition & 1 deletion tests/snapshots/hacs-test-org/appdaemon-basic/test_remove_repository_post.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@
"area_id": null,
"attributes": {
"auto_update": false,
"entity_picture": "https://brands.home-assistant.io/_/hacs/icon.png",
"entity_picture": "/api/brands/integration/hacs/icon.png",
"friendly_name": "HACS update",
"in_progress": false,
"installed_version": "0.0.0",
Expand Down
2 changes: 1 addition & 1 deletion tests/snapshots/hacs-test-org/appdaemon-basic/test_remove_repository_pre.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@
"area_id": null,
"attributes": {
"auto_update": false,
"entity_picture": "https://brands.home-assistant.io/_/hacs/icon.png",
"entity_picture": "/api/brands/integration/hacs/icon.png",
"friendly_name": "HACS update",
"in_progress": false,
"installed_version": "0.0.0",
Expand Down
2 changes: 1 addition & 1 deletion tests/snapshots/hacs-test-org/appdaemon-basic/test_update_repository_entity.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,7 @@
"area_id": null,
"attributes": {
"auto_update": false,
"entity_picture": "https://brands.home-assistant.io/_/hacs/icon.png",
"entity_picture": "/api/brands/integration/hacs/icon.png",
"friendly_name": "HACS update",
"in_progress": false,
"installed_version": "0.0.0",
Expand Down
2 changes: 1 addition & 1 deletion tests/snapshots/hacs-test-org/appdaemon-basic/test_update_repository_websocket.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@
"area_id": null,
"attributes": {
"auto_update": false,
"entity_picture": "https://brands.home-assistant.io/_/hacs/icon.png",
"entity_picture": "/api/brands/integration/hacs/icon.png",
"friendly_name": "HACS update",
"in_progress": false,
"installed_version": "0.0.0",
Expand Down
2 changes: 1 addition & 1 deletion tests/snapshots/hacs-test-org/integration-basic/test_discard_invalid_repo_data.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@
"area_id": null,
"attributes": {
"auto_update": false,
"entity_picture": "https://brands.home-assistant.io/_/hacs/icon.png",
"entity_picture": "/api/brands/integration/hacs/icon.png",
"friendly_name": "HACS update",
"in_progress": false,
"installed_version": "0.0.0",
Expand Down
4 changes: 2 additions & 2 deletions tests/snapshots/hacs-test-org/integration-basic/test_download_repository.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@
"area_id": null,
"attributes": {
"auto_update": false,
"entity_picture": "https://brands.home-assistant.io/_/example/icon.png",
"entity_picture": "/api/brands/integration/example/icon.png",
"friendly_name": "Proxy manifest update",
"in_progress": false,
"installed_version": "1.0.0",
Expand Down Expand Up @@ -126,7 +126,7 @@
"area_id": null,
"attributes": {
"auto_update": false,
"entity_picture": "https://brands.home-assistant.io/_/hacs/icon.png",
"entity_picture": "/api/brands/integration/hacs/icon.png",
"friendly_name": "HACS update",
"in_progress": false,
"installed_version": "0.0.0",
Expand Down
2 changes: 1 addition & 1 deletion tests/snapshots/hacs-test-org/integration-basic/test_remove_repository_post.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@
"area_id": null,
"attributes": {
"auto_update": false,
"entity_picture": "https://brands.home-assistant.io/_/hacs/icon.png",
"entity_picture": "/api/brands/integration/hacs/icon.png",
"friendly_name": "HACS update",
"in_progress": false,
"installed_version": "0.0.0",
Expand Down
2 changes: 1 addition & 1 deletion tests/snapshots/hacs-test-org/integration-basic/test_remove_repository_pre.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@
"area_id": null,
"attributes": {
"auto_update": false,
"entity_picture": "https://brands.home-assistant.io/_/hacs/icon.png",
"entity_picture": "/api/brands/integration/hacs/icon.png",
"friendly_name": "HACS update",
"in_progress": false,
"installed_version": "0.0.0",
Expand Down
4 changes: 2 additions & 2 deletions tests/snapshots/hacs-test-org/integration-basic/test_switch/entity_states.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
"initial": {
"attributes": {
"auto_update": false,
"entity_picture": "https://brands.home-assistant.io/_/example/icon.png",
"entity_picture": "/api/brands/integration/example/icon.png",
"friendly_name": "Basic integration update",
"in_progress": false,
"installed_version": "1.0.0",
Expand All @@ -48,7 +48,7 @@
"updated": {
"attributes": {
"auto_update": false,
"entity_picture": "https://brands.home-assistant.io/_/example/icon.png",
"entity_picture": "/api/brands/integration/example/icon.png",
"friendly_name": "Basic integration update",
"in_progress": false,
"installed_version": "1.0.0",
Expand Down
4 changes: 2 additions & 2 deletions tests/snapshots/hacs-test-org/integration-basic/test_update_entity_state.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"initial_state": {
"attributes": {
"auto_update": false,
"entity_picture": "https://brands.home-assistant.io/_/example/icon.png",
"entity_picture": "/api/brands/integration/example/icon.png",
"friendly_name": "Basic integration update",
"in_progress": false,
"installed_version": "1.0.0",
Expand All @@ -23,7 +23,7 @@
"updated_state": {
"attributes": {
"auto_update": false,
"entity_picture": "https://brands.home-assistant.io/_/example/icon.png",
"entity_picture": "/api/brands/integration/example/icon.png",
"friendly_name": "Basic integration update",
"in_progress": false,
"installed_version": "1.0.0",
Expand Down
4 changes: 2 additions & 2 deletions tests/snapshots/hacs-test-org/integration-basic/test_update_repository_entity.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@
"area_id": null,
"attributes": {
"auto_update": false,
"entity_picture": "https://brands.home-assistant.io/_/example/icon.png",
"entity_picture": "/api/brands/integration/example/icon.png",
"friendly_name": "Proxy manifest update",
"in_progress": false,
"installed_version": "2.0.0",
Expand Down Expand Up @@ -141,7 +141,7 @@
"area_id": null,
"attributes": {
"auto_update": false,
"entity_picture": "https://brands.home-assistant.io/_/hacs/icon.png",
"entity_picture": "/api/brands/integration/hacs/icon.png",
"friendly_name": "HACS update",
"in_progress": false,
"installed_version": "0.0.0",
Expand Down
2 changes: 1 addition & 1 deletion tests/snapshots/hacs-test-org/integration-basic/test_update_repository_websocket.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@
"area_id": null,
"attributes": {
"auto_update": false,
"entity_picture": "https://brands.home-assistant.io/_/hacs/icon.png",
"entity_picture": "/api/brands/integration/hacs/icon.png",
"friendly_name": "HACS update",
"in_progress": false,
"installed_version": "0.0.0",
Expand Down
2 changes: 1 addition & 1 deletion tests/snapshots/hacs-test-org/plugin-basic/test_discard_invalid_repo_data.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@
"area_id": null,
"attributes": {
"auto_update": false,
"entity_picture": "https://brands.home-assistant.io/_/hacs/icon.png",
"entity_picture": "/api/brands/integration/hacs/icon.png",
"friendly_name": "HACS update",
"in_progress": false,
"installed_version": "0.0.0",
Expand Down
2 changes: 1 addition & 1 deletion tests/snapshots/hacs-test-org/plugin-basic/test_download_repository.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@
"area_id": null,
"attributes": {
"auto_update": false,
"entity_picture": "https://brands.home-assistant.io/_/hacs/icon.png",
"entity_picture": "/api/brands/integration/hacs/icon.png",
"friendly_name": "HACS update",
"in_progress": false,
"installed_version": "0.0.0",
Expand Down
2 changes: 1 addition & 1 deletion tests/snapshots/hacs-test-org/plugin-basic/test_remove_repository_post.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@
"area_id": null,
"attributes": {
"auto_update": false,
"entity_picture": "https://brands.home-assistant.io/_/hacs/icon.png",
"entity_picture": "/api/brands/integration/hacs/icon.png",
"friendly_name": "HACS update",
"in_progress": false,
"installed_version": "0.0.0",
Expand Down
2 changes: 1 addition & 1 deletion tests/snapshots/hacs-test-org/plugin-basic/test_remove_repository_pre.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@
"area_id": null,
"attributes": {
"auto_update": false,
"entity_picture": "https://brands.home-assistant.io/_/hacs/icon.png",
"entity_picture": "/api/brands/integration/hacs/icon.png",
"friendly_name": "HACS update",
"in_progress": false,
"installed_version": "0.0.0",
Expand Down
2 changes: 1 addition & 1 deletion tests/snapshots/hacs-test-org/plugin-basic/test_update_repository_entity.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@
"area_id": null,
"attributes": {
"auto_update": false,
"entity_picture": "https://brands.home-assistant.io/_/hacs/icon.png",
"entity_picture": "/api/brands/integration/hacs/icon.png",
"friendly_name": "HACS update",
"in_progress": false,
"installed_version": "0.0.0",
Expand Down
2 changes: 1 addition & 1 deletion tests/snapshots/hacs-test-org/plugin-basic/test_update_repository_websocket.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@
"area_id": null,
"attributes": {
"auto_update": false,
"entity_picture": "https://brands.home-assistant.io/_/hacs/icon.png",
"entity_picture": "/api/brands/integration/hacs/icon.png",
"friendly_name": "HACS update",
"in_progress": false,
"installed_version": "0.0.0",
Expand Down
2 changes: 1 addition & 1 deletion tests/snapshots/hacs-test-org/python_script-basic/test_discard_invalid_repo_data.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@
"area_id": null,
"attributes": {
"auto_update": false,
"entity_picture": "https://brands.home-assistant.io/_/hacs/icon.png",
"entity_picture": "/api/brands/integration/hacs/icon.png",
"friendly_name": "HACS update",
"in_progress": false,
"installed_version": "0.0.0",
Expand Down
2 changes: 1 addition & 1 deletion tests/snapshots/hacs-test-org/python_script-basic/test_download_repository.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@
"area_id": null,
"attributes": {
"auto_update": false,
"entity_picture": "https://brands.home-assistant.io/_/hacs/icon.png",
"entity_picture": "/api/brands/integration/hacs/icon.png",
"friendly_name": "HACS update",
"in_progress": false,
"installed_version": "0.0.0",
Expand Down
2 changes: 1 addition & 1 deletion tests/snapshots/hacs-test-org/python_script-basic/test_remove_repository_post.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@
"area_id": null,
"attributes": {
"auto_update": false,
"entity_picture": "https://brands.home-assistant.io/_/hacs/icon.png",
"entity_picture": "/api/brands/integration/hacs/icon.png",
"friendly_name": "HACS update",
"in_progress": false,
"installed_version": "0.0.0",
Expand Down
2 changes: 1 addition & 1 deletion tests/snapshots/hacs-test-org/python_script-basic/test_remove_repository_pre.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@
"area_id": null,
"attributes": {
"auto_update": false,
"entity_picture": "https://brands.home-assistant.io/_/hacs/icon.png",
"entity_picture": "/api/brands/integration/hacs/icon.png",
"friendly_name": "HACS update",
"in_progress": false,
"installed_version": "0.0.0",
Expand Down
2 changes: 1 addition & 1 deletion tests/snapshots/hacs-test-org/python_script-basic/test_update_repository_entity.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,7 @@
"area_id": null,
"attributes": {
"auto_update": false,
"entity_picture": "https://brands.home-assistant.io/_/hacs/icon.png",
"entity_picture": "/api/brands/integration/hacs/icon.png",
"friendly_name": "HACS update",
"in_progress": false,
"installed_version": "0.0.0",
Expand Down
2 changes: 1 addition & 1 deletion tests/snapshots/hacs-test-org/python_script-basic/test_update_repository_websocket.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@
"area_id": null,
"attributes": {
"auto_update": false,
"entity_picture": "https://brands.home-assistant.io/_/hacs/icon.png",
"entity_picture": "/api/brands/integration/hacs/icon.png",
"friendly_name": "HACS update",
"in_progress": false,
"installed_version": "0.0.0",
Expand Down
2 changes: 1 addition & 1 deletion tests/snapshots/hacs-test-org/template-basic/test_discard_invalid_repo_data.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@
"area_id": null,
"attributes": {
"auto_update": false,
"entity_picture": "https://brands.home-assistant.io/_/hacs/icon.png",
"entity_picture": "/api/brands/integration/hacs/icon.png",
"friendly_name": "HACS update",
"in_progress": false,
"installed_version": "0.0.0",
Expand Down
2 changes: 1 addition & 1 deletion tests/snapshots/hacs-test-org/template-basic/test_download_repository.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@
"area_id": null,
"attributes": {
"auto_update": false,
"entity_picture": "https://brands.home-assistant.io/_/hacs/icon.png",
"entity_picture": "/api/brands/integration/hacs/icon.png",
"friendly_name": "HACS update",
"in_progress": false,
"installed_version": "0.0.0",
Expand Down
2 changes: 1 addition & 1 deletion tests/snapshots/hacs-test-org/template-basic/test_remove_repository_post.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@
"area_id": null,
"attributes": {
"auto_update": false,
"entity_picture": "https://brands.home-assistant.io/_/hacs/icon.png",
"entity_picture": "/api/brands/integration/hacs/icon.png",
"friendly_name": "HACS update",
"in_progress": false,
"installed_version": "0.0.0",
Expand Down
2 changes: 1 addition & 1 deletion tests/snapshots/hacs-test-org/template-basic/test_remove_repository_pre.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@
"area_id": null,
"attributes": {
"auto_update": false,
"entity_picture": "https://brands.home-assistant.io/_/hacs/icon.png",
"entity_picture": "/api/brands/integration/hacs/icon.png",
"friendly_name": "HACS update",
"in_progress": false,
"installed_version": "0.0.0",
Expand Down
2 changes: 1 addition & 1 deletion tests/snapshots/hacs-test-org/template-basic/test_update_repository_entity.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@
"area_id": null,
"attributes": {
"auto_update": false,
"entity_picture": "https://brands.home-assistant.io/_/hacs/icon.png",
"entity_picture": "/api/brands/integration/hacs/icon.png",
"friendly_name": "HACS update",
"in_progress": false,
"installed_version": "0.0.0",
Expand Down
2 changes: 1 addition & 1 deletion tests/snapshots/hacs-test-org/template-basic/test_update_repository_websocket.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@
"area_id": null,
"attributes": {
"auto_update": false,
"entity_picture": "https://brands.home-assistant.io/_/hacs/icon.png",
"entity_picture": "/api/brands/integration/hacs/icon.png",
"friendly_name": "HACS update",
"in_progress": false,
"installed_version": "0.0.0",
Expand Down
2 changes: 1 addition & 1 deletion tests/snapshots/hacs-test-org/theme-basic/test_discard_invalid_repo_data.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@
"area_id": null,
"attributes": {
"auto_update": false,
"entity_picture": "https://brands.home-assistant.io/_/hacs/icon.png",
"entity_picture": "/api/brands/integration/hacs/icon.png",
"friendly_name": "HACS update",
"in_progress": false,
"installed_version": "0.0.0",
Expand Down
2 changes: 1 addition & 1 deletion tests/snapshots/hacs-test-org/theme-basic/test_download_repository.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@
"area_id": null,
"attributes": {
"auto_update": false,
"entity_picture": "https://brands.home-assistant.io/_/hacs/icon.png",
"entity_picture": "/api/brands/integration/hacs/icon.png",
"friendly_name": "HACS update",
"in_progress": false,
"installed_version": "0.0.0",
Expand Down
2 changes: 1 addition & 1 deletion tests/snapshots/hacs-test-org/theme-basic/test_remove_repository_post.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@
"area_id": null,
"attributes": {
"auto_update": false,
"entity_picture": "https://brands.home-assistant.io/_/hacs/icon.png",
"entity_picture": "/api/brands/integration/hacs/icon.png",
"friendly_name": "HACS update",
"in_progress": false,
"installed_version": "0.0.0",
Expand Down
2 changes: 1 addition & 1 deletion tests/snapshots/hacs-test-org/theme-basic/test_remove_repository_pre.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@
"area_id": null,
"attributes": {
"auto_update": false,
"entity_picture": "https://brands.home-assistant.io/_/hacs/icon.png",
"entity_picture": "/api/brands/integration/hacs/icon.png",
"friendly_name": "HACS update",
"in_progress": false,
"installed_version": "0.0.0",
Expand Down
2 changes: 1 addition & 1 deletion tests/snapshots/hacs-test-org/theme-basic/test_update_repository_entity.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,7 @@
"area_id": null,
"attributes": {
"auto_update": false,
"entity_picture": "https://brands.home-assistant.io/_/hacs/icon.png",
"entity_picture": "/api/brands/integration/hacs/icon.png",
"friendly_name": "HACS update",
"in_progress": false,
"installed_version": "0.0.0",
Expand Down
2 changes: 1 addition & 1 deletion tests/snapshots/hacs-test-org/theme-basic/test_update_repository_websocket.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@
"area_id": null,
"attributes": {
"auto_update": false,
"entity_picture": "https://brands.home-assistant.io/_/hacs/icon.png",
"entity_picture": "/api/brands/integration/hacs/icon.png",
"friendly_name": "HACS update",
"in_progress": false,
"installed_version": "0.0.0",
Expand Down
2 changes: 1 addition & 1 deletion tests/snapshots/test_integration_setup.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@
"area_id": null,
"attributes": {
"auto_update": false,
"entity_picture": "https://brands.home-assistant.io/_/hacs/icon.png",
"entity_picture": "/api/brands/integration/hacs/icon.png",
"friendly_name": "HACS update",
"in_progress": false,
"installed_version": "0.0.0",
Expand Down