Skip to content

Haddock3 container workflow & usage#1318

Closed
Comp-era wants to merge 17 commits into
haddocking:mainfrom
Comp-era:usage-run-build-container
Closed

Haddock3 container workflow & usage#1318
Comp-era wants to merge 17 commits into
haddocking:mainfrom
Comp-era:usage-run-build-container

Conversation

@Comp-era

@Comp-era Comp-era commented Jul 9, 2025

Copy link
Copy Markdown

This PR adds a top-level usage-container/ directory from the Comp-era/HADDOCK3-Container repo,
containing:

  • README.md (detailed container usage guide)
  • docs/usage.md (run instructions)
  • recipe/ (example build definition)
  • scripts/ (Slurm run scripts)

It also updates the root README.md to link to this guide.

@rvhonorato
rvhonorato requested review from a team and amjjbonvin July 9, 2025 13:01
@rvhonorato rvhonorato added documentation Improve docs community Feature requests / contribution / issues from users labels Jul 9, 2025
Comment thread usage-container/LICENSE Outdated
Comment thread usage-container/CONTRIBUTING.md Outdated

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine for your own repo - should rather be removed here if distributed with haddock3

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CONTRIBUTING.md has now been removed.

Comment thread README.md Outdated

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this the minimal set of dependencies?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are the minimal set of dependencies to build and run haddock3

Comment thread usage-container/README.md Outdated
@Comp-era

Comp-era commented Aug 5, 2025

Copy link
Copy Markdown
Author

All requested changes have been made. PR ready for re-review

@rvhonorato
rvhonorato requested review from a team and amjjbonvin August 14, 2025 15:45

@amjjbonvin amjjbonvin left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have now a mix of local haddock3 repo links and links pointing to https://github.com/Comp-era/HADDOCK3-Container
Not sure what is best. If this is mainly documentation, we could rather add the content to the HADDOCK3 user manual instead.
Or we have everything in the haddock3 repo.

Comment thread usage-container/README.md Outdated

A ready-to-use Docker image for HADDOCK3 is published on the GitHub container registry, simply pull:
```bash
docker pull ghcr.io/haddocking/haddock3:2025.5.0

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have now released 2025.8.0 - so should this command be made more generic to pull the latest version?

And add a second command to pull a specific version

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull command has been made generic with :latest and added a second example to pin 2025.8.0 for reproducibility.

Comment thread usage-container/README.md Outdated
# Or, build with Singularity
singularity build haddock3_mpi.sif docker://ghcr.io/haddocking/haddock3:2025.5.0
```
**Note:** Refer to the [**usage.md**](https://github.com/Comp-era/HADDOCK3-Container/blob/main/docs/usage.md) and the example SLURM script available in the `scripts` folder for detailed instructions on how to run HADDOCK3 jobs in an HPC environment.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this the same usage.md file as in this pull request? if yes then rather link to the local one

@Comp-era Comp-era Aug 25, 2025

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Link has been updated with local HADDOCK3 repo

Comment thread usage-container/scripts/slurm_run._apptainer.sh
Comment thread usage-container/README.md

---

### Build Your Own HADDOCK3 Container

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is still pointing to https://github.com/Comp-era/HADDOCK3-Container - if we make it part of the haddock3 repo, we should rather point to the local haddock3 repo files.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Link updated with local haddock3 repo files.

@github-actions

github-actions Bot commented Oct 2, 2025

Copy link
Copy Markdown

This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions Bot added the Stale label Oct 2, 2025
@Comp-era

Comp-era commented Oct 2, 2025

Copy link
Copy Markdown
Author

All comments have been resolved. Happy to make any additional edits if required!

@rvhonorato
rvhonorato requested review from a team and amjjbonvin October 3, 2025 10:35
@rvhonorato rvhonorato removed the Stale label Oct 3, 2025

srun --partition=compute \
--nodes=1 \
--ntasks-per-node=8 \

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice to add somewhere some explanations on how to change the number of cpu used. Now the example gives 8, but is this a dynamic variable that the container will automatically take over? Or do you need to rebuild the container in case a different number of cpus should be used?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Required changes have been incorporated. The documentation now clarifies that the number of CPUs can be adjusted dynamically through the SLURM command and does not require rebuilding the container. Also added relevant information pertaining to usage of the container.


#SBATCH --job-name=HADDOCK3-docking
#SBATCH --output=HADDOCK3_%j.out
#SBATCH --nodes=3

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here we are requesting 3 nodes with each 120 tasks. Somewhere it should be made clear that the mpi run mode of HADDOCK3 must then be used in the config file.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The documentation now explicitly mentions that when running on multiple nodes, the HADDOCK3 configuration file must be set to use the MPI run mode. Clarifications on changing the number of CPU cores have also been added, along with the same information reflected in the SLURM batch script.

@github-actions

github-actions Bot commented Nov 7, 2025

Copy link
Copy Markdown

This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions Bot added the Stale label Nov 7, 2025
@amjjbonvin

Copy link
Copy Markdown
Member

@Comp-era - please check the last comments not yet answered

@github-actions github-actions Bot removed the Stale label Nov 8, 2025
Comment thread usage-container/docs/usage.md
Comment thread usage-container/recipe/haddock3_mpi.def Outdated
Comment thread usage-container/scripts/slurm_run_apptainer.sh Outdated
Comment thread usage-container/README.md Outdated
Comment thread usage-container/README.md
Comment thread usage-container/docs/usage.md Outdated

@rvhonorato rvhonorato left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After reading trough this, I think it will fit better in https://github.com/haddocking/haddock3-user-manual instead of here.

@Comp-era

Copy link
Copy Markdown
Author

Thanks for the suggestion. Is there a designated location within https://github.com/haddocking/haddock3-user-manual where I should submit a pull request for the same?

@rvhonorato

Copy link
Copy Markdown
Member

you can just make a PR there and the reviewers can decide where it fits best.

@Comp-era

Comp-era commented Dec 1, 2025

Copy link
Copy Markdown
Author

As suggested, I have created a PR within https://github.com/haddocking/haddock3-user-manual. Once the reviewers decide the location, I’ll update the directory paths accordingly to match the designated structure.

@github-actions

github-actions Bot commented Jan 1, 2026

Copy link
Copy Markdown

This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions Bot added the Stale label Jan 1, 2026
@rvhonorato

Copy link
Copy Markdown
Member

moved to haddocking/haddock3-user-manual#25

@rvhonorato rvhonorato closed this Jan 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

community Feature requests / contribution / issues from users documentation Improve docs Stale

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants