fix: Handle no file category scenario (#867)

Author: kingston

.changeset/skip-storage-module-no-categories.md

@@ -0,0 +1,5 @@
+---
+'@baseplate-dev/plugin-storage': patch
+---
+
+Skip generating storage file handling code (upload services, presigned URLs, schemas, and upload components) when no file categories are configured

plugins/plugin-storage/src/storage/core/components/file-category-editor-form.tsx

@@ -73,7 +73,9 @@ function FileCategoryEditorForm({
         <SectionListSectionTitle>File Categories</SectionListSectionTitle>
         <SectionListSectionDescription>
           Configure file categories that define upload constraints, storage
-          adapters, and authorization rules for file uploads.
+          adapters, and authorization rules for file uploads. If no file
+          categories are specified, storage file handling code (upload services,
+          presigned URLs, and related schemas) will not be generated.
         </SectionListSectionDescription>
       </SectionListSectionHeader>
       <SectionListSectionContent className="storage:space-y-4">

plugins/plugin-storage/src/storage/core/components/storage-definition-editor.tsx

@@ -28,7 +28,10 @@ import {
 import { zodResolver } from '@hookform/resolvers/zod';
 import { useMemo } from 'react';
 
-import type { StoragePluginDefinitionInput } from '../schema/plugin-definition.js';
+import type {
+  StoragePluginDefinition,
+  StoragePluginDefinitionInput,
+} from '../schema/plugin-definition.js';
 
 import { createStoragePartialDefinition } from '../schema/models.js';
 import { createStoragePluginDefinitionSchema } from '../schema/plugin-definition.js';
@@ -58,7 +61,8 @@ export function StorageDefinitionEditor({
         'storage',
       ),
       s3Adapters: [],
-    } satisfies StoragePluginDefinitionInput;
+      fileCategories: [],
+    } satisfies StoragePluginDefinition;
   }, [definition, pluginMetadata?.config]);
 
   const form = useResettableForm({

plugins/plugin-storage/src/storage/core/node.ts

@@ -33,16 +33,19 @@ export default createPluginModule({
             pluginKey,
           ) as StoragePluginDefinition;
 
-          // add feature providers
-          appCompiler.addChildrenToFeature(storage.storageFeatureRef, {
-            storage: storageModuleGenerator({
-              s3Adapters: storage.s3Adapters.map((a) => ({
-                name: a.name,
-                bucketConfigVar: a.bucketConfigVar,
-                hostedUrlConfigVar: a.hostedUrlConfigVar,
-              })),
-            }),
-          });
+          // add feature providers (only when file categories are configured,
+          // since nearly all storage module templates depend on categories)
+          if (storage.fileCategories.length > 0) {
+            appCompiler.addChildrenToFeature(storage.storageFeatureRef, {
+              storage: storageModuleGenerator({
+                s3Adapters: storage.s3Adapters.map((a) => ({
+                  name: a.name,
+                  bucketConfigVar: a.bucketConfigVar,
+                  hostedUrlConfigVar: a.hostedUrlConfigVar,
+                })),
+              }),
+            });
+          }
 
           // Collect file transformers with resolved categories
           const transformers = projectDefinition.models.flatMap((m) =>
@@ -146,7 +149,16 @@ export default createPluginModule({
       pluginAppCompiler({
         pluginKey,
         appType: webAppEntryType,
-        compile: ({ appCompiler, appDefinition }) => {
+        compile: ({ appCompiler, appDefinition, projectDefinition }) => {
+          const webStorage = PluginUtils.configByKeyOrThrow(
+            projectDefinition,
+            pluginKey,
+          ) as StoragePluginDefinition;
+
+          if (webStorage.fileCategories.length === 0) {
+            return;
+          }
+
           if (
             !appDefinition.includeUploadComponents &&
             !appDefinition.adminApp.enabled