fix: Fix create/update input schemas to only include their respective fields (#870)

Author: kingston

.changeset/fix-input-schema-field-filtering.md

@@ -0,0 +1,5 @@
+---
+'@baseplate-dev/fastify-generators': patch
+---
+
+Fix create/update input schemas to only include their respective fields using Zod `.pick()`, make fieldSchemas a `z.object()`, skip transform path when the operation has no transform fields, and omit unused `context` parameter in scalar-only methods without auth

examples/blog-with-auth/apps/backend/baseplate/generated/src/modules/accounts/users/schema/user.mutations.ts

@@ -43,6 +43,7 @@ const updateUserDataInputType = builder
   .inputType('UpdateUserData', {
     fields: (t) => ({
       email: t.string(),
+      phone: t.string(),
       name: t.string(),
       emailVerified: t.boolean(),
     }),

examples/blog-with-auth/apps/backend/baseplate/generated/src/modules/accounts/users/services/user.data-service.ts

@@ -9,15 +9,18 @@ import type { ServiceContext } from '@src/utils/service-context.js';
 import { prisma } from '@src/services/prisma.js';
 import { checkGlobalAuthorization } from '@src/utils/authorizers.js';
 
-const userFieldSchemas = {
+const userFieldSchemas = z.object({
   email: z.string().nullish(),
+  phone: z.string().nullish(),
   name: z.string().nullish(),
   emailVerified: z.boolean().optional(),
-};
+});
 
-export const userCreateSchema = z.object(userFieldSchemas);
-
-export const userUpdateSchema = z.object(userFieldSchemas).partial();
+export const userCreateSchema = userFieldSchemas.pick({
+  email: true,
+  name: true,
+  emailVerified: true,
+});
 
 export async function createUser<TQuery extends DataQuery<'user'>>({
   data,
@@ -38,6 +41,8 @@ export async function createUser<TQuery extends DataQuery<'user'>>({
   return result as GetResult<'user', TQuery>;
 }
 
+export const userUpdateSchema = userFieldSchemas.partial();
+
 export async function updateUser<TQuery extends DataQuery<'user'>>({
   where,
   data,

examples/blog-with-auth/apps/backend/baseplate/generated/src/modules/articles/services/article.data-service.ts

@@ -9,11 +9,12 @@ import type { ServiceContext } from '@src/utils/service-context.js';
 import { prisma } from '@src/services/prisma.js';
 import { checkGlobalAuthorization } from '@src/utils/authorizers.js';
 
-const articleFieldSchemas = { title: z.string(), content: z.string() };
+const articleFieldSchemas = z.object({
+  title: z.string(),
+  content: z.string(),
+});
 
-export const articleCreateSchema = z.object(articleFieldSchemas);
-
-export const articleUpdateSchema = z.object(articleFieldSchemas).partial();
+export const articleCreateSchema = articleFieldSchemas;
 
 export async function createArticle<TQuery extends DataQuery<'article'>>({
   data,
@@ -34,6 +35,8 @@ export async function createArticle<TQuery extends DataQuery<'article'>>({
   return result as GetResult<'article', TQuery>;
 }
 
+export const articleUpdateSchema = articleFieldSchemas.partial();
+
 export async function updateArticle<TQuery extends DataQuery<'article'>>({
   where,
   data,

examples/blog-with-auth/apps/backend/baseplate/generated/src/modules/blogs/services/blog-post.data-service.ts

@@ -11,7 +11,7 @@ import { prisma } from '@src/services/prisma.js';
 import { checkGlobalAuthorization } from '@src/utils/authorizers.js';
 import { relationHelpers } from '@src/utils/data-operations/relation-helpers.js';
 
-const blogPostFieldSchemas = {
+const blogPostFieldSchemas = z.object({
   blogId: z.uuid(),
   publisherId: z.uuid(),
   title: z.string(),
@@ -20,11 +20,9 @@ const blogPostFieldSchemas = {
     .json()
     .transform((val) => (val === null ? Prisma.JsonNull : val))
     .optional(),
-};
+});
 
-export const blogPostCreateSchema = z.object(blogPostFieldSchemas);
-
-export const blogPostUpdateSchema = z.object(blogPostFieldSchemas).partial();
+export const blogPostCreateSchema = blogPostFieldSchemas;
 
 export async function createBlogPost<TQuery extends DataQuery<'blogPost'>>({
   data,
@@ -50,6 +48,8 @@ export async function createBlogPost<TQuery extends DataQuery<'blogPost'>>({
   return result as GetResult<'blogPost', TQuery>;
 }
 
+export const blogPostUpdateSchema = blogPostFieldSchemas.partial();
+
 export async function updateBlogPost<TQuery extends DataQuery<'blogPost'>>({
   where,
   data,

examples/blog-with-auth/apps/backend/baseplate/generated/src/modules/blogs/services/blog.data-service.ts

@@ -12,9 +12,9 @@ import { relationHelpers } from '@src/utils/data-operations/relation-helpers.js'
 
 import { blogAuthorizer } from '../authorizers/blog.authorizer.js';
 
-const blogFieldSchemas = { name: z.string(), userId: z.uuid() };
+const blogFieldSchemas = z.object({ name: z.string(), userId: z.uuid() });
 
-export const blogUpdateSchema = z.object(blogFieldSchemas).partial();
+export const blogUpdateSchema = blogFieldSchemas.partial();
 
 export async function updateBlog<TQuery extends DataQuery<'blog'>>({
   where,

examples/blog-with-auth/apps/backend/src/modules/accounts/users/schema/user.mutations.ts

@@ -43,6 +43,7 @@ const updateUserDataInputType = builder
   .inputType('UpdateUserData', {
     fields: (t) => ({
       email: t.string(),
+      phone: t.string(),
       name: t.string(),
       emailVerified: t.boolean(),
     }),

examples/blog-with-auth/apps/backend/src/modules/accounts/users/services/user.data-service.ts

@@ -9,15 +9,18 @@ import type { ServiceContext } from '@src/utils/service-context.js';
 import { prisma } from '@src/services/prisma.js';
 import { checkGlobalAuthorization } from '@src/utils/authorizers.js';
 
-const userFieldSchemas = {
+const userFieldSchemas = z.object({
   email: z.string().nullish(),
+  phone: z.string().nullish(),
   name: z.string().nullish(),
   emailVerified: z.boolean().optional(),
-};
+});
 
-export const userCreateSchema = z.object(userFieldSchemas);
-
-export const userUpdateSchema = z.object(userFieldSchemas).partial();
+export const userCreateSchema = userFieldSchemas.pick({
+  email: true,
+  name: true,
+  emailVerified: true,
+});
 
 export async function createUser<TQuery extends DataQuery<'user'>>({
   data,
@@ -38,6 +41,8 @@ export async function createUser<TQuery extends DataQuery<'user'>>({
   return result as GetResult<'user', TQuery>;
 }
 
+export const userUpdateSchema = userFieldSchemas.partial();
+
 export async function updateUser<TQuery extends DataQuery<'user'>>({
   where,
   data,

examples/blog-with-auth/apps/backend/src/modules/articles/services/article.data-service.ts

@@ -9,11 +9,12 @@ import type { ServiceContext } from '@src/utils/service-context.js';
 import { prisma } from '@src/services/prisma.js';
 import { checkGlobalAuthorization } from '@src/utils/authorizers.js';
 
-const articleFieldSchemas = { title: z.string(), content: z.string() };
+const articleFieldSchemas = z.object({
+  title: z.string(),
+  content: z.string(),
+});
 
-export const articleCreateSchema = z.object(articleFieldSchemas);
-
-export const articleUpdateSchema = z.object(articleFieldSchemas).partial();
+export const articleCreateSchema = articleFieldSchemas;
 
 export async function createArticle<TQuery extends DataQuery<'article'>>({
   data,
@@ -34,6 +35,8 @@ export async function createArticle<TQuery extends DataQuery<'article'>>({
   return result as GetResult<'article', TQuery>;
 }
 
+export const articleUpdateSchema = articleFieldSchemas.partial();
+
 export async function updateArticle<TQuery extends DataQuery<'article'>>({
   where,
   data,

examples/blog-with-auth/apps/backend/src/modules/blogs/services/blog-post.data-service.ts

@@ -11,7 +11,7 @@ import { prisma } from '@src/services/prisma.js';
 import { checkGlobalAuthorization } from '@src/utils/authorizers.js';
 import { relationHelpers } from '@src/utils/data-operations/relation-helpers.js';
 
-const blogPostFieldSchemas = {
+const blogPostFieldSchemas = z.object({
   blogId: z.uuid(),
   publisherId: z.uuid(),
   title: z.string(),
@@ -20,11 +20,9 @@ const blogPostFieldSchemas = {
     .json()
     .transform((val) => (val === null ? Prisma.JsonNull : val))
     .optional(),
-};
+});
 
-export const blogPostCreateSchema = z.object(blogPostFieldSchemas);
-
-export const blogPostUpdateSchema = z.object(blogPostFieldSchemas).partial();
+export const blogPostCreateSchema = blogPostFieldSchemas;
 
 export async function createBlogPost<TQuery extends DataQuery<'blogPost'>>({
   data,
@@ -50,6 +48,8 @@ export async function createBlogPost<TQuery extends DataQuery<'blogPost'>>({
   return result as GetResult<'blogPost', TQuery>;
 }
 
+export const blogPostUpdateSchema = blogPostFieldSchemas.partial();
+
 export async function updateBlogPost<TQuery extends DataQuery<'blogPost'>>({
   where,
   data,