chore: Upgrade vite to 7.3.2 instead of 7.3.1#883
Conversation
|
| Name | Type |
|---|---|
| @baseplate-dev/core-generators | Patch |
| @baseplate-dev/react-generators | Patch |
| @baseplate-dev/fastify-generators | Patch |
| @baseplate-dev/project-builder-server | Patch |
| @baseplate-dev/plugin-ai | Patch |
| @baseplate-dev/plugin-auth | Patch |
| @baseplate-dev/plugin-email | Patch |
| @baseplate-dev/plugin-observability | Patch |
| @baseplate-dev/plugin-payments | Patch |
| @baseplate-dev/plugin-queue | Patch |
| @baseplate-dev/plugin-rate-limit | Patch |
| @baseplate-dev/plugin-storage | Patch |
| @baseplate-dev/create-project | Patch |
| @baseplate-dev/project-builder-cli | Patch |
| @baseplate-dev/project-builder-common | Patch |
| @baseplate-dev/project-builder-dev | Patch |
| @baseplate-dev/project-builder-web | Patch |
| @baseplate-dev/project-builder-test | Patch |
| @baseplate-dev/code-morph | Patch |
| @baseplate-dev/project-builder-lib | Patch |
| @baseplate-dev/sync | Patch |
| @baseplate-dev/tools | Patch |
| @baseplate-dev/ui-components | Patch |
| @baseplate-dev/utils | Patch |
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (1)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
📝 WalkthroughWalkthroughThis PR upgrades Vite from version 7.3.1 to 7.3.2 across the codebase, including example applications, package generator constants, and workspace configuration. The change also excludes Vite from the minimum release age constraint in pnpm-workspace.yaml. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
pnpm-workspace.yaml (1)
42-44: Consider time-bounding theminimumReleaseAgeExcludeforvite.This exception is reasonable for an urgent bump, but it can weaken supply-chain guardrails if left indefinitely. Consider adding a short comment/TODO with removal criteria.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@pnpm-workspace.yaml` around lines 42 - 44, The entry under minimumReleaseAgeExclude that lists "vite" should be time-bounded and documented: update the pnpm-workspace.yaml to add a short inline comment/TODO next to the vite exclusion indicating why it was added, the specific removal criteria (e.g., date or resolved issue/PR number), and a target expiry (e.g., 30/60/90 days); ensure the comment references the minimumReleaseAgeExclude key and the "vite" value so reviewers can easily find and remove the exception when the criteria are met.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.changeset/upgrade-vite-to-7-3-2.md:
- Line 6: Update the changeset description line that currently reads "Upgrade
vite version from 7.1.12 to 7.3.2" to the correct source version "Upgrade vite
version from 7.3.1 to 7.3.2" in the .changeset/upgrade-vite-to-7-3-2.md file so
the released notes match the PR scope; locate and edit the literal string in
that file to reflect 7.3.1 -> 7.3.2.
---
Nitpick comments:
In `@pnpm-workspace.yaml`:
- Around line 42-44: The entry under minimumReleaseAgeExclude that lists "vite"
should be time-bounded and documented: update the pnpm-workspace.yaml to add a
short inline comment/TODO next to the vite exclusion indicating why it was
added, the specific removal criteria (e.g., date or resolved issue/PR number),
and a target expiry (e.g., 30/60/90 days); ensure the comment references the
minimumReleaseAgeExclude key and the "vite" value so reviewers can easily find
and remove the exception when the criteria are met.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 0ea5e3d0-30bb-48c5-ab6c-4082677e29f7
⛔ Files ignored due to path filters (11)
examples/blog-with-auth/apps/admin/baseplate/generated/package.jsonis excluded by!**/generated/**,!**/generated/**examples/blog-with-auth/apps/backend/baseplate/generated/package.jsonis excluded by!**/generated/**,!**/generated/**examples/blog-with-auth/libs/transactional/baseplate/generated/package.jsonis excluded by!**/generated/**,!**/generated/**examples/blog-with-auth/pnpm-lock.yamlis excluded by!**/pnpm-lock.yamlexamples/todo-with-better-auth/apps/admin/baseplate/generated/package.jsonis excluded by!**/generated/**,!**/generated/**examples/todo-with-better-auth/apps/backend/baseplate/generated/package.jsonis excluded by!**/generated/**,!**/generated/**examples/todo-with-better-auth/apps/web/baseplate/generated/package.jsonis excluded by!**/generated/**,!**/generated/**examples/todo-with-better-auth/libs/transactional/baseplate/generated/package.jsonis excluded by!**/generated/**,!**/generated/**examples/todo-with-better-auth/pnpm-lock.yamlis excluded by!**/pnpm-lock.yamlpnpm-lock.yamlis excluded by!**/pnpm-lock.yamltests/simple/snapshots/root/diffs/pnpm-lock.yaml.diffis excluded by!tests/**
📒 Files selected for processing (11)
.changeset/upgrade-vite-to-7-3-2.mdexamples/blog-with-auth/apps/admin/package.jsonexamples/blog-with-auth/apps/backend/package.jsonexamples/blog-with-auth/libs/transactional/package.jsonexamples/todo-with-better-auth/apps/admin/package.jsonexamples/todo-with-better-auth/apps/backend/package.jsonexamples/todo-with-better-auth/apps/web/package.jsonexamples/todo-with-better-auth/libs/transactional/package.jsonpackages/core-generators/src/constants/core-packages.tspackages/react-generators/src/constants/react-packages.tspnpm-workspace.yaml
| --- | ||
|
|
||
| Upgrade vite version from 7.1.12 to 7.3.1 | ||
| Upgrade vite version from 7.1.12 to 7.3.2 |
There was a problem hiding this comment.
Fix the source version in the changeset description.
The description says 7.1.12 -> 7.3.2, but this PR is scoped to 7.3.1 -> 7.3.2. Please align the text to avoid misleading release notes.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In @.changeset/upgrade-vite-to-7-3-2.md at line 6, Update the changeset
description line that currently reads "Upgrade vite version from 7.1.12 to
7.3.2" to the correct source version "Upgrade vite version from 7.3.1 to 7.3.2"
in the .changeset/upgrade-vite-to-7-3-2.md file so the released notes match the
PR scope; locate and edit the literal string in that file to reflect 7.3.1 ->
7.3.2.
Summary by CodeRabbit