Skip to content

Commit a404cd2

Browse files
halibobo1205claude
andcommitted
fix: add missing field validations in servlet test verify matchers
Address PR #119 new review comments from CodeAnt AI: - UpdateWitnessServletTest: validate update_url field - MarketCancelOrderServletTest: validate order_id (32 bytes) - VoteWitnessAccountServletTest: validate vote_address in votes - TransferAssetServletTest: validate asset_name - ParticipateAssetIssueServletTest: validate asset_name Note: resource enum field (BANDWIDTH) not asserted for FreezeBalanceV2/UnFreezeBalanceV2/DelegateResource/UnDelegateResource because JsonFormat.merge() does not parse the resource field — BANDWIDTH is the protobuf default (0), so asserting it would not prove parsing correctness. This is a pre-existing base branch behavior. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
1 parent fc3e80e commit a404cd2

5 files changed

Lines changed: 14 additions & 5 deletions

File tree

framework/src/test/java/org/tron/core/services/http/MarketCancelOrderServletTest.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,8 @@ public void testMarketCancelOrder() throws Exception {
4242
verify(wallet).createTransactionCapsule(
4343
argThat(c -> c instanceof MarketCancelOrderContract
4444
&& addressEquals(((MarketCancelOrderContract) c)
45-
.getOwnerAddress(), ownerAddr)),
45+
.getOwnerAddress(), ownerAddr)
46+
&& ((MarketCancelOrderContract) c).getOrderId().size() == 32),
4647
eq(ContractType.MarketCancelOrderContract));
4748
assertTransactionResponse(response);
4849
}

framework/src/test/java/org/tron/core/services/http/ParticipateAssetIssueServletTest.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,9 @@ && addressEquals(((AssetIssueContractOuterClass.ParticipateAssetIssueContract) c
5050
&& addressEquals(((AssetIssueContractOuterClass.ParticipateAssetIssueContract) c)
5151
.getToAddress(), toAddr)
5252
&& ((AssetIssueContractOuterClass.ParticipateAssetIssueContract) c)
53-
.getAmount() == 100),
53+
.getAmount() == 100
54+
&& ((AssetIssueContractOuterClass.ParticipateAssetIssueContract) c)
55+
.getAssetName().toStringUtf8().equals("test")),
5456
eq(Protocol.Transaction.Contract.ContractType.ParticipateAssetIssueContract));
5557
assertTransactionResponse(response);
5658
}

framework/src/test/java/org/tron/core/services/http/TransferAssetServletTest.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,9 @@ && addressEquals(((AssetIssueContractOuterClass.TransferAssetContract) c)
4949
.getOwnerAddress(), ownerAddr)
5050
&& addressEquals(((AssetIssueContractOuterClass.TransferAssetContract) c)
5151
.getToAddress(), toAddr)
52-
&& ((AssetIssueContractOuterClass.TransferAssetContract) c).getAmount() == 100),
52+
&& ((AssetIssueContractOuterClass.TransferAssetContract) c).getAmount() == 100
53+
&& ((AssetIssueContractOuterClass.TransferAssetContract) c)
54+
.getAssetName().toStringUtf8().equals("test")),
5355
eq(Protocol.Transaction.Contract.ContractType.TransferAssetContract));
5456
assertTransactionResponse(response);
5557
}

framework/src/test/java/org/tron/core/services/http/UpdateWitnessServletTest.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,9 @@ public void testUpdateWitness() throws Exception {
4343
verify(wallet).createTransactionCapsule(
4444
argThat(c -> c instanceof WitnessContract.WitnessUpdateContract
4545
&& addressEquals(((WitnessContract.WitnessUpdateContract) c)
46-
.getOwnerAddress(), ownerAddr)),
46+
.getOwnerAddress(), ownerAddr)
47+
&& ((WitnessContract.WitnessUpdateContract) c)
48+
.getUpdateUrl().toStringUtf8().equals("test_url")),
4749
eq(Protocol.Transaction.Contract.ContractType.WitnessUpdateContract));
4850
assertTransactionResponse(response);
4951
}

framework/src/test/java/org/tron/core/services/http/VoteWitnessAccountServletTest.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,9 @@ public void testVoteWitnessAccount() throws Exception {
4545
argThat(c -> c instanceof VoteWitnessContract
4646
&& addressEquals(((VoteWitnessContract) c).getOwnerAddress(), ownerAddr)
4747
&& ((VoteWitnessContract) c).getVotesCount() == 1
48-
&& ((VoteWitnessContract) c).getVotes(0).getVoteCount() == 1),
48+
&& ((VoteWitnessContract) c).getVotes(0).getVoteCount() == 1
49+
&& addressEquals(((VoteWitnessContract) c).getVotes(0)
50+
.getVoteAddress(), voteAddr)),
4951
eq(ContractType.VoteWitnessContract));
5052
assertTransactionResponse(response);
5153
}

0 commit comments

Comments
 (0)