Skip to content

Commit c0d2eb4

Browse files
committed
Fix bugs in testing-make.yml
* Make workflow much less eager * Check status rather than use continue-on-error, which suppresses failures * Install pybind11 on macOS
1 parent 8240b88 commit c0d2eb4

1 file changed

Lines changed: 29 additions & 8 deletions

File tree

.github/workflows/testing-make.yml

Lines changed: 29 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,27 @@ on:
1010
- ".github/**"
1111
- "!.github/workflows/testing-make.yml"
1212

13+
- "CMakeLists.txt"
14+
- "CMakePresets.json"
15+
- "**.cmake"
16+
- "vcpkg.json"
17+
- "vcpkg-configuration.json"
18+
19+
- "doc/**"
20+
- "packaging/**"
21+
- "python_bindings/**"
22+
23+
- "pyproject.toml"
24+
- "uv.lock"
25+
26+
- "README.md"
27+
- "CODE_OF_CONDUCT.md"
28+
- "LICENSE.txt"
29+
- ".gitignore"
30+
- ".gitattributes"
31+
- ".gitmodules"
32+
- ".lldbinit"
33+
1334
concurrency:
1435
group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }}
1536
cancel-in-progress: true
@@ -40,7 +61,7 @@ jobs:
4061
build-essential pkg-config libpng-dev libjpeg-turbo8-dev \
4162
"llvm-${LLVM_VERSION}-dev" "clang-${LLVM_VERSION}" "lld-${LLVM_VERSION}" "liblld-${LLVM_VERSION}-dev"
4263
elif [ "$RUNNER_OS" = "macOS" ]; then
43-
brew install "llvm@${LLVM_VERSION}" "lld@${LLVM_VERSION}" libjpeg-turbo libpng pkgconf protobuf
64+
brew install "llvm@${LLVM_VERSION}" "lld@${LLVM_VERSION}" libjpeg-turbo libpng pkgconf protobuf pybind11
4465
fi
4566
4667
- name: Set up environment
@@ -55,22 +76,22 @@ jobs:
5576
- run: make build_tests
5677

5778
- run: make test_internal
58-
continue-on-error: true
79+
if: ${{ !cancelled() }}
5980

6081
- run: make test_correctness
61-
continue-on-error: true
82+
if: ${{ !cancelled() }}
6283

6384
- run: make test_generator
64-
continue-on-error: true
85+
if: ${{ !cancelled() }}
6586

6687
- run: make test_error
67-
continue-on-error: true
88+
if: ${{ !cancelled() }}
6889

6990
- run: make test_warning
70-
continue-on-error: true
91+
if: ${{ !cancelled() }}
7192

7293
- run: make test_apps
73-
continue-on-error: true
94+
if: ${{ !cancelled() }}
7495

7596
- run: make test_tutorial
76-
continue-on-error: true
97+
if: ${{ !cancelled() }}

0 commit comments

Comments
 (0)