Skip to content

Satisfy ruff.#8934

Merged
alexreinking merged 1 commit into
halide:mainfrom
mcourteaux:satisfy-ruff
Feb 5, 2026
Merged

Satisfy ruff.#8934
alexreinking merged 1 commit into
halide:mainfrom
mcourteaux:satisfy-ruff

Conversation

@mcourteaux
Copy link
Copy Markdown
Contributor

No description provided.

@mcourteaux mcourteaux added the skip_buildbots Do not run buildbots on this PR. Must add before opening PR as we scan labels immediately. label Feb 5, 2026
@mcourteaux
Copy link
Copy Markdown
Contributor Author

mcourteaux commented Feb 5, 2026

@alexreinking Will GHA run unconditionally now? Can we change this to run the GHA only upon manual approval? Where is the clang-format check?

@alexreinking
Copy link
Copy Markdown
Member

Will GHA run unconditionally now?

For now, yes. We can add some file pattern exclusions to the Make workflow if we wish.

Can we change this to run the GHA only upon manual approval?

I'd really rather we didn't require any manual intervention to run CI.

Where is the clang-format check?

Not running because of the file filter at the top of the workflow.

@alexreinking alexreinking merged commit 141affc into halide:main Feb 5, 2026
3 checks passed
@mcourteaux
Copy link
Copy Markdown
Contributor Author

Where is the clang-format check?

Not running because of the file filter at the top of the workflow.

Aha, I guess this needs changing then because we this PR changes python code, which requires ruff to run. Unless we split out clang-format and ruff to two different CI steps.

@alexreinking
Copy link
Copy Markdown
Member

Unless we split out clang-format and ruff to two different CI steps.

That would be fine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip_buildbots Do not run buildbots on this PR. Must add before opening PR as we scan labels immediately.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants