Skip to content

Skip extent-one dimensions in a device copy #8957

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
abadams merged 3 commits into from
Feb 21, 2026
Merged

Skip extent-one dimensions in a device copy #8957

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0c734bb
Skip extent-one dimensions in a device copy
abadams Feb 20, 2026
7c92aec
Add test
abadams Feb 20, 2026
1d796f0
Add SKIP annotation
abadams Feb 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/runtime/device_buffer_utils.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,6 +129,10 @@ WEAK device_copy make_buffer_copy(const halide_buffer_t *src, bool src_host,
// are added to the copy by inserting it such that the stride is
// in ascending order in the dst.
for (int i = 0; i < dst->dimensions; i++) {
// Skip extent-one dimensions
if (dst->dim[i].extent == 1) {
continue;
}
// TODO: deal with negative strides.
uint64_t dst_stride_bytes = (uint64_t)dst->dim[i].stride * dst->type.bytes();
uint64_t src_stride_bytes = (uint64_t)src->dim[i].stride * src->type.bytes();
Expand All @@ -147,7 +151,6 @@ WEAK device_copy make_buffer_copy(const halide_buffer_t *src, bool src_host,
c.src_stride_bytes[j] = c.src_stride_bytes[j - 1];
}
c.extent[insert] = min(src->dim[i].extent, dst->dim[i].extent);
// debug(nullptr) << "c.extent[" << insert << "] = " << (int)(c.extent[insert]) << "\n";
c.dst_stride_bytes[insert] = dst_stride_bytes;
c.src_stride_bytes[insert] = src_stride_bytes;
};
Expand All @@ -174,6 +177,7 @@ WEAK device_copy make_buffer_copy(const halide_buffer_t *src, bool src_host,
c.src_stride_bytes[MAX_COPY_DIMS - 1] = 0;
c.dst_stride_bytes[MAX_COPY_DIMS - 1] = 0;
}

return c;
}

Expand Down
Loading