Refine clang-tidy configuration for the runtime#9032
Merged
alexreinking merged 2 commits intomainfrom Mar 16, 2026
Merged
Conversation
mcourteaux
approved these changes
Mar 15, 2026
| - "packaging/**" | ||
| - "Makefile" | ||
| - "Makefile.inc" | ||
| - 'run-clang-tidy.sh' |
Contributor
There was a problem hiding this comment.
Clang tidy is extremely slow. Do we really need to run it on all build targets? This is to have it check different permutations of the code, based on platform specific preprocessor macros?
Member
Author
There was a problem hiding this comment.
This is an exclusion so that the ARM Linux workflows don't run if we only modified the clang-tidy configuration.
Member
Author
There was a problem hiding this comment.
Of course, since we modified the workflows themselves, they are running.
mcourteaux
approved these changes
Mar 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #9024 I noticed a comment about clang-tidy not respecting disabling checks that were matched by a wildcard. Maybe that was true in clang-tidy 16 (as indicated by the comment), but it is not true today!
Also refine the
./run-clang-tidy.shscript to:sedfilter wouldn't catch them.patch_filefunctionjqto better handle merging the runtime compile-commands databases