Skip to content

IRGraph C++ Printer. #9042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mcourteaux wants to merge 13 commits into
base: main
Choose a base branch
from
+484 −7
Open

IRGraph C++ Printer. #9042

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
864a26d
First version of the IRGraph printer for C++ code.
mcourteaux Mar 15, 2026
a6716de
typo and clang violation
mcourteaux Mar 15, 2026
28aefd2
Try again
mcourteaux Mar 15, 2026
c029361
Moved implementation of the IRGraphCXXPrinter to the cpp file.
mcourteaux Mar 15, 2026
2832427
Cleanup
mcourteaux Mar 15, 2026
40d4780
Apply pre-commit auto-fixes
halide-ci[bot] Mar 15, 2026
c19a87d
Expand test.
mcourteaux Mar 15, 2026
c3b1a22
Don't pretend that we will IR print Stmts.
mcourteaux Mar 16, 2026
fe19a36
more clang-tidy;
mcourteaux Mar 16, 2026
3af8c26
Support printing Call statements.
mcourteaux Mar 17, 2026
4a59bb2
Add string-based testing for IRGraphCXXPrinter.
mcourteaux Mar 23, 2026
6ea527a
Move IRGraphCXXPrinter to test/fuzz
mcourteaux Apr 10, 2026
ce4c6ee
Move IRGraphCXXPrinter to the fuzz folder and fixup compilation, and …
mcourteaux Apr 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1286,7 +1286,7 @@ PERFORMANCE_TESTS = $(shell ls $(ROOT_DIR)/test/performance/*.cpp)
ERROR_TESTS = $(shell ls $(ROOT_DIR)/test/error/*.cpp)
WARNING_TESTS = $(shell ls $(ROOT_DIR)/test/warning/*.cpp)
RUNTIME_TESTS = $(shell ls $(ROOT_DIR)/test/runtime/*.cpp)
FUZZ_TESTS = $(filter-out %halide_fuzz_main.cpp, $(shell ls $(ROOT_DIR)/test/fuzz/*.cpp))
FUZZ_TESTS = $(filter-out %halide_fuzz_main.cpp %IRGraphCXXPrinter.cpp, $(shell ls $(ROOT_DIR)/test/fuzz/*.cpp))
GENERATOR_EXTERNAL_TESTS := $(shell ls $(ROOT_DIR)/test/generator/*test.cpp)
GENERATOR_EXTERNAL_TEST_GENERATOR := $(shell ls $(ROOT_DIR)/test/generator/*_generator.cpp)
TUTORIALS = $(filter-out %_generate.cpp, $(shell ls $(ROOT_DIR)/tutorial/*.cpp))
Expand Down Expand Up @@ -1475,7 +1475,7 @@ $(BIN_DIR)/$(TARGET)/correctness_opencl_runtime: $(ROOT_DIR)/test/correctness/op
$(BIN_DIR)/performance_%: $(ROOT_DIR)/test/performance/%.cpp $(TEST_DEPS)
$(CXX) $(TEST_CXX_FLAGS) $(OPTIMIZE) $< -I$(INCLUDE_DIR) -I$(ROOT_DIR)/src/runtime -I$(ROOT_DIR)/test/common $(TEST_LD_FLAGS) -o $@

$(BIN_DIR)/fuzz_%: $(ROOT_DIR)/test/fuzz/%.cpp $(ROOT_DIR)/test/fuzz/halide_fuzz_main.cpp $(ROOT_DIR)/test/fuzz/fuzz_helpers.h $(ROOT_DIR)/test/fuzz/halide_fuzz_main.h $(TEST_DEPS)
$(BIN_DIR)/fuzz_%: $(ROOT_DIR)/test/fuzz/%.cpp $(ROOT_DIR)/test/fuzz/halide_fuzz_main.cpp $(ROOT_DIR)/test/fuzz/fuzz_helpers.h $(ROOT_DIR)/test/fuzz/halide_fuzz_main.h $(ROOT_DIR)/test/fuzz/IRGraphCXXPrinter.cpp $(ROOT_DIR)/test/fuzz/IRGraphCXXPrinter.h $(TEST_DEPS)
$(CXX) $(TEST_CXX_FLAGS) -I$(ROOT_DIR)/src/runtime -I$(ROOT_DIR)/test/common $(OPTIMIZE_FOR_BUILD_TIME) $(filter %.cpp,$^) -I$(INCLUDE_DIR) $(TEST_LD_FLAGS) -o $@ -DHALIDE_FUZZER_BACKEND=0

# Error tests that link against libHalide
Expand Down
14 changes: 9 additions & 5 deletions test/fuzz/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,20 +36,24 @@ extern "C" int LLVMFuzzerTestOneInput(const uint8_t *Data, std::size_t Size) {
}
]] HAVE_LIBFUZZER_FLAGS)

add_library(Halide_fuzz INTERFACE)
add_library(Halide_fuzz OBJECT)
add_library(Halide::fuzz ALIAS Halide_fuzz)

target_sources(Halide_fuzz PRIVATE IRGraphCXXPrinter.cpp)
target_link_libraries(Halide_fuzz PRIVATE Halide::Test)

if (NOT HAVE_LIBFUZZER_FLAGS)
if (LIB_FUZZING_ENGINE)
message(FATAL_ERROR "Cannot set LIB_FUZZING_ENGINE when not building with -fsanitize=fuzzer or a compatible fuzzing engine.")
endif ()
target_sources(Halide_fuzz INTERFACE halide_fuzz_main.cpp halide_fuzz_main.h)
target_compile_definitions(Halide_fuzz INTERFACE HALIDE_FUZZER_BACKEND=HALIDE_FUZZER_BACKEND_STDLIB)
target_sources(Halide_fuzz PRIVATE halide_fuzz_main.cpp halide_fuzz_main.h)
target_compile_definitions(Halide_fuzz PUBLIC HALIDE_FUZZER_BACKEND=HALIDE_FUZZER_BACKEND_STDLIB)
else ()
target_link_libraries(Halide_fuzz INTERFACE ${LIB_FUZZING_ENGINE})
target_compile_definitions(Halide_fuzz INTERFACE HALIDE_FUZZER_BACKEND=HALIDE_FUZZER_BACKEND_LIBFUZZER)
target_link_libraries(Halide_fuzz PUBLIC ${LIB_FUZZING_ENGINE})
target_compile_definitions(Halide_fuzz PUBLIC HALIDE_FUZZER_BACKEND=HALIDE_FUZZER_BACKEND_LIBFUZZER)
endif ()


Copy link
Copy Markdown
Member

@alexreinking alexreinking Apr 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why?

Copy link
Copy Markdown
Contributor Author

@mcourteaux mcourteaux Apr 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fuzz simplify complained for me that HALIDE_FUZZER_BACKEND is undefined. It's no longer the INTERFACE library, but an OBJECT library, so I think it's normal you have to declare it as a PUBLIC compile definition?

Copy link
Copy Markdown
Member

@alexreinking alexreinking Apr 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, the extra blank line

Copy link
Copy Markdown
Contributor Author

@mcourteaux mcourteaux Apr 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, didn't realize. precommit didn't complain :P

foreach (fuzzer IN LISTS TEST_NAMES)
target_link_libraries("${fuzzer}" PRIVATE Halide::fuzz)
endforeach ()
Loading
Loading