Fix double-lookups into Scope and map#9062
Merged
mcourteaux merged 1 commit intomainfrom Mar 19, 2026
Merged
Conversation
In several places we were checking something was in a scope, and if so, looking it up again to actually do something with it. We should use ::find (or ::shallow_find for a mutable reference into a Scope) No functional impact.
alexreinking
approved these changes
Mar 18, 2026
mcourteaux
approved these changes
Mar 19, 2026
Contributor
|
Failure is: #9055 (comment) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In several places we were checking something was in a scope, and if so, looking it up again to actually do something with it. We should use ::find (or ::shallow_find for a mutable reference into a Scope)
No functional impact.