Skip to content

Add missing visit_base call to bounds fuzzer #9064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexreinking merged 1 commit into from
Mar 19, 2026
+21 −5
Merged

Add missing visit_base call to bounds fuzzer #9064

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 21 additions & 5 deletions test/fuzz/bounds.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -415,7 +415,7 @@ bool test_bounds(Expr test, const Interval &interval, Type t, const map<string,
return true;
}

bool test_expression_bounds(FuzzingContext &fuzz, Expr test, int trials, int samples_per_trial) {
bool test_expression_bounds(FuzzingContext &fuzz, Expr test, int trials, int samples_per_trial, bool minimize_failures = true) {
map<string, Expr> vars;
for (int i = 0; i < fuzz_var_count; i++) {
vars[fuzz_var(i)] = Expr();
Expand All @@ -429,6 +429,7 @@ bool test_expression_bounds(FuzzingContext &fuzz, Expr test, int trials, int sam
contains_risky_cast |= (op->type.is_int() &&
op->type.bits() >= 32 &&
!op->type.can_represent(op->value.type()));
self->visit_base(op);
});
if (contains_risky_cast) {
return true;
Expand Down Expand Up @@ -472,11 +473,26 @@ bool test_expression_bounds(FuzzingContext &fuzz, Expr test, int trials, int sam
}

if (!test_bounds(test, interval, test.type(), vars)) {
std::cerr << "scope {\n";
for (auto v = vars.begin(); v != vars.end(); v++) {
std::cerr << "\t" << v->first << " : " << scope.get(v->first) << "\n";
// Try to minimize it to an incorrect sub-expression
bool found_failure = false;
if (minimize_failures) {
std::cerr << "Attempting to minimize failure...\n";
mutate_with(test, [&](auto *self, const Expr &e) {
Copy link
Copy Markdown
Contributor

@mcourteaux mcourteaux Mar 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't this be a visitor?

self->mutate_base(e);
if (!found_failure && !e.same_as(test)) {
found_failure |= !test_expression_bounds(fuzz, e, trials * 10, samples_per_trial * 10, false);
}
return e;
});
}

if (!found_failure) {
std::cerr << "scope {\n";
for (auto v = vars.begin(); v != vars.end(); v++) {
std::cerr << "\t" << v->first << " : " << scope.get(v->first) << "\n";
}
std::cerr << "}\n";
}
std::cerr << "}\n";
return false;
}
}
Expand Down
Loading