Report clang-tidy errors as GitHub annotations#9078
Merged
alexreinking merged 1 commit intomainfrom Mar 26, 2026
Merged
Conversation
Member
|
How have you tested this (asking almost entirely because I'm curious to see what it looks like)? |
Member
Author
I tested the script by running it locally... I could push an intentional clang-tidy violation here and we can see what it does. |
Member
Author
So that's what I would expect. |
Member
|
Very nice. |
abadams
approved these changes
Mar 26, 2026
alexreinking
force-pushed
the
alexreinking/clang-tidy-feedback
branch
from
088c205 to
d4a67bb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #9077 had some clang-tidy failures, but digging through the logs to see what's wrong isn't fun. This PR turns the
clang-tidyerror messages into commit/PR annotations.