Merge pull request #78 from bstoker/bstoker/fix/allow_null_title_in_image

Allow null title in image

Author: halilozercan

android-sample/src/main/java/com/zachklipp/richtext/sample/MarkdownSample.kt

@@ -243,7 +243,9 @@ private val sampleMarkdown = """
 
   ## Images
   
-  Inline-style: 
+  Inline-style:
+   
+  ![random image](https://picsum.photos/seed/picsum/400/400)
   
   ![random image](https://picsum.photos/seed/picsum/400/400 "Text 1")
   

richtext-commonmark/build.gradle.kts

@@ -41,5 +41,12 @@ kotlin {
         implementation(Commonmark.strikethrough)
       }
     }
+
+    val jvmTest by getting {
+      kotlin.srcDir("src/commonJvmAndroidTest/kotlin")
+      dependencies {
+        implementation(Kotlin.Test.jdk)
+      }
+    }
   }
 }

richtext-commonmark/src/commonJvmAndroid/kotlin/com/halilibo/richtext/markdown/AstNodeConvert.kt

@@ -112,12 +112,12 @@ internal fun convert(
       literal = node.literal
     )
     is Image -> {
-      if (node.title == null || node.destination == null) {
+      if (node.destination == null) {
         null
       }
       else {
         AstImage(
-          title = node.title,
+          title = node.title ?: "",
           destination = node.destination
         )
       }

richtext-commonmark/src/commonJvmAndroidTest/kotlin/com/halilibo/richtext/markdown/AstNodeConvertKtTest.kt

@@ -0,0 +1,27 @@
+package com.halilibo.richtext.markdown
+
+import com.halilibo.richtext.markdown.node.AstImage
+import com.halilibo.richtext.markdown.node.AstNode
+import com.halilibo.richtext.markdown.node.AstNodeLinks
+import org.commonmark.node.Image
+import org.junit.Test
+import kotlin.test.assertEquals
+
+internal class AstNodeConvertKtTest {
+
+  @Test
+  fun `when image without title is converted, then the content description is empty`() {
+    val destination = "/url"
+    val image = Image(destination, null)
+
+    val result = convert(image)
+
+    assertEquals(
+      expected = AstNode(
+        type = AstImage(title = "", destination = destination),
+        links = AstNodeLinks()
+      ),
+      actual = result
+    )
+  }
+}