Skip to content

Commit edff0f6

Browse files
authored
Merge pull request #127 from halilozercan/halilozercan/fix-publish-workflow
Fix publish workflow
2 parents fcce206 + a4f0037 commit edff0f6

9 files changed

Lines changed: 33 additions & 34 deletions

File tree

android-sample/src/main/AndroidManifest.xml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
1-
<manifest xmlns:android="http://schemas.android.com/apk/res/android"
2-
package="com.zachklipp.richtext.sample">
1+
<manifest xmlns:android="http://schemas.android.com/apk/res/android">
32

43
<uses-permission android:name="android.permission.INTERNET" />
54

build.gradle.kts

Lines changed: 20 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,7 @@
11
// Top-level build file where you can add configuration options common to all sub-projects/modules.
2-
import com.android.build.gradle.LibraryExtension
32
import com.android.build.gradle.internal.cxx.configure.gradleLocalProperties
43
import org.jetbrains.dokka.gradle.DokkaMultiModuleTask
54
import org.jetbrains.dokka.gradle.DokkaTaskPartial
6-
import org.jetbrains.kotlin.gradle.dsl.KotlinMultiplatformExtension
75
import org.jetbrains.kotlin.gradle.tasks.KotlinCompile
86

97
buildscript {
@@ -64,6 +62,10 @@ subprojects {
6462
return@afterEvaluate
6563
}
6664

65+
tasks.withType<AbstractPublishToMaven>().configureEach {
66+
dependsOn(tasks.withType<Sign>())
67+
}
68+
6769
tasks.named<DokkaTaskPartial>("dokkaHtmlPartial").configure {
6870
dokkaSourceSets.configureEach {
6971
reportUndocumented.set(true)
@@ -81,27 +83,27 @@ subprojects {
8183
archiveClassifier.set("javadoc")
8284
from(tasks.dokkaJavadoc.flatMap { it.outputDirectory })
8385
}
84-
}
85-
86-
afterEvaluate {
87-
val androidExtension = extensions.findByType<LibraryExtension>()
88-
val multiplatformExtension = extensions.findByType<KotlinMultiplatformExtension>()
8986

90-
fun MavenPublication.configure() {
91-
if (multiplatformExtension == null && androidExtension != null) {
92-
val androidSourcesJar by tasks.registering(Jar::class) {
93-
archiveClassifier.set("sources")
94-
from(androidExtension.sourceSets["main"].java.srcDirs)
95-
}
96-
artifact(androidSourcesJar.get())
97-
from(components["release"])
87+
if (tasks.names.contains("publishKotlinMultiplatformPublicationToMavenRepository")) {
88+
tasks.named("publishKotlinMultiplatformPublicationToMavenRepository").configure {
89+
dependsOn("signJvmPublication")
9890
}
91+
}
9992

100-
artifact(tasks.named("javadocJar").get())
93+
if (tasks.names.contains("publishAndroidReleasePublicationToMavenRepository")) {
94+
tasks.named("publishAndroidReleasePublicationToMavenRepository").configure {
95+
dependsOn("signJvmPublication")
96+
}
97+
}
98+
}
10199

100+
afterEvaluate {
101+
fun MavenPublication.configure() {
102102
groupId = property("GROUP").toString()
103103
version = property("VERSION_NAME").toString()
104104

105+
artifact(tasks.named("javadocJar").get())
106+
105107
pom {
106108
name.set(property("POM_NAME").toString())
107109
description.set(property("POM_DESCRIPTION").toString())
@@ -157,16 +159,8 @@ subprojects {
157159
}
158160
}
159161

160-
if (multiplatformExtension != null) {
161-
publications.withType<MavenPublication>().configureEach {
162-
configure()
163-
}
164-
} else if (androidExtension != null) {
165-
// Add publications for Android libraries.
166-
// KMP libraries already have MavenPublications that are added by multiplatform plugin
167-
publications.register<MavenPublication>("release") {
168-
afterEvaluate { configure() }
169-
}
162+
publications.withType<MavenPublication>().configureEach {
163+
configure()
170164
}
171165
}
172166

buildSrc/src/main/kotlin/richtext-android-library.gradle.kts

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,4 +32,10 @@ android {
3232
composeOptions {
3333
kotlinCompilerExtensionVersion = Compose.compilerVersion
3434
}
35+
36+
publishing {
37+
singleVariant("release") {
38+
withSourcesJar()
39+
}
40+
}
3541
}

buildSrc/src/main/kotlin/richtext-kmp-library.gradle.kts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ repositories {
1313
kotlin {
1414
jvm()
1515
android {
16-
publishLibraryVariants("release", "debug")
16+
publishLibraryVariants("release")
1717
compilations.all {
1818
kotlinOptions.jvmTarget = "11"
1919
}
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
<manifest package="com.halilibo.richtext.markdown" />
1+
<manifest />
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
<manifest package="com.halilibo.richtext.ui.material" />
1+
<manifest />
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
<manifest package="com.halilibo.richtext.ui.material3" />
1+
<manifest />
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
<manifest package="com.halilibo.richtext.ui" />
1+
<manifest />
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
<manifest package="com.zachklipp.richtext.ui.slideshow" />
1+
<manifest />

0 commit comments

Comments
 (0)