Skip to content

Commit 17b3f1f

Browse files
authored
Merge branch 'main' into feat/placeholder
2 parents 255dfa1 + 8f3c016 commit 17b3f1f

3 files changed

Lines changed: 33 additions & 24 deletions

File tree

packages/comment-widget/src/base-comment-item.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -77,6 +77,7 @@ export class BaseCommentItem extends LitElement {
7777
<user-avatar
7878
src="${this.userAvatar || ''}"
7979
alt="${this.userDisplayName || ''}"
80+
href=${this.userWebsite}
8081
></user-avatar>
8182
</div>
8283
<div class="item-main flex-[1_1_auto] min-w-0 w-full">
@@ -87,6 +88,7 @@ export class BaseCommentItem extends LitElement {
8788
class="item-author font-medium text-sm"
8889
target="_blank"
8990
href=${this.userWebsite}
91+
rel="noopener noreferrer"
9092
>
9193
${this.userDisplayName}
9294
</a>`

packages/comment-widget/src/styles/content.css

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
-ms-text-size-adjust: 100%;
1010
-webkit-text-size-adjust: 100%;
1111
margin: 0;
12-
color: var(--halo-cw-text-1-color);
12+
color: var(--halo-cw-text-1-color, #111827);
1313
font-family: var(--base-font-family);
1414
font-size: var(--base-font-size);
1515
line-height: var(--base-line-height);
@@ -39,7 +39,7 @@
3939

4040
.markdown-body mark {
4141
background-color: var(--bgColor-attention-muted);
42-
color: var(--halo-cw-text-1-color);
42+
color: var(--halo-cw-text-1-color, #111827);
4343
}
4444

4545
.markdown-body sub,
@@ -78,11 +78,11 @@
7878
box-sizing: content-box;
7979
overflow: hidden;
8080
background: transparent;
81-
border-bottom: 1px solid var(--halo-cw-muted-1-color);
81+
border-bottom: 1px solid var(--halo-cw-muted-1-color, #d1d5db);
8282
height: 0.25em;
8383
padding: 0;
8484
margin: 1.4em 0;
85-
background-color: var(--halo-cw-muted-1-color);
85+
background-color: var(--halo-cw-muted-1-color, #d1d5db);
8686
border: 0;
8787
}
8888

@@ -134,8 +134,8 @@
134134
.markdown-body blockquote {
135135
margin: 0;
136136
padding: 0 1em;
137-
color: var(--base-info-color);
138-
border-left: 0.25em solid var(--borderColor-default);
137+
color: var(--halo-cw-text-1-color, #111827);
138+
border-left: 0.25em solid var(--halo-cw-muted-1-color, #d1d5db);
139139
}
140140

141141
.markdown-body ul,
@@ -256,7 +256,7 @@
256256
margin: 0;
257257
font-size: 85%;
258258
white-space: break-spaces;
259-
background-color: var(--halo-cw-muted-1-color);
259+
background-color: var(--halo-cw-muted-2-color, #e5e7eb);
260260
border-radius: 6px;
261261
}
262262

packages/comment-widget/src/user-avatar.ts

Lines changed: 24 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,9 @@ export class UserAvatar extends LitElement {
1010
@property({ type: String })
1111
alt: string | undefined;
1212

13+
@property({ type: String })
14+
href: string | undefined;
15+
1316
@state()
1417
error = false;
1518

@@ -63,29 +66,33 @@ export class UserAvatar extends LitElement {
6366
}
6467

6568
override render() {
66-
if (this.src) {
67-
if (this.loading) {
68-
return html`<div class="avatar">
69-
<icon-loading></icon-loading>
70-
</div>`;
71-
}
72-
73-
if (this.error) {
74-
return html`<div class="avatar">
75-
<i class="i-tabler:alert-circle size-5"></i>
76-
</div>`;
77-
}
78-
79-
return html`<div class="avatar">
80-
<img class="avatar-image size-full object-cover" src="${this.src}" alt="${this.alt || ''}" loading="lazy" />
81-
</div>`;
69+
if (this.href) {
70+
return html`<a class="avatar" href="${this.href}" target="_blank" rel="noopener noreferrer">
71+
${this.renderAvatarContent()}
72+
</a>`;
8273
}
8374

8475
return html`<div class="avatar">
85-
<span class="avatar-placeholder text-sm font-medium text-text-1 select-none">${this.getPlaceholderText()}</span>
76+
${this.renderAvatarContent()}
8677
</div>`;
8778
}
8879

80+
renderAvatarContent() {
81+
if (!this.src) {
82+
return html`<span class="avatar-placeholder text-sm font-medium text-text-1 select-none">${this.getPlaceholderText()}</span>`;
83+
}
84+
85+
if (this.loading) {
86+
return html`<icon-loading></icon-loading>`;
87+
}
88+
89+
if (this.error) {
90+
return html`<i class="i-tabler:alert-circle size-5"></i>`;
91+
}
92+
93+
return html`<img class="avatar-image size-full object-cover" src="${this.src}" alt="${this.alt || ''}" loading="lazy" />`;
94+
}
95+
8996
static override styles = [
9097
...baseStyles,
9198
css`

0 commit comments

Comments
 (0)