Skip to content

Commit 220219d

Browse files
authored
fix: wrong reply size (#117)
如果开启了 `同时加载评论的回复`,然后异步加载下一页回复时,改为使用 `同时加载回复的条数` 的值,如果和以前一样的 `默认加载回复条数` 选项作为 size 参数,那么可能出现无法正确获取下一页数据的问题。 Fixes #114 ```release-note 修复开启 `同时加载回复的条数` 选项时,可能无法正确加载下一页的问题 ```
1 parent f04fb71 commit 220219d

3 files changed

Lines changed: 12 additions & 6 deletions

File tree

build.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,5 +41,5 @@ build {
4141
}
4242

4343
halo {
44-
version = "2.14.0"
44+
version = "2.15.0-rc.1"
4545
}

packages/comment-widget/src/comment-replies.ts

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,7 @@ export class CommentReplies extends LitElement {
9292
this.page = 1;
9393
}
9494

95-
const queryParams = [`page=${this.page || 0}`, `size=${this.replySize}`];
95+
const queryParams = [`page=${this.page || 1}`, `size=${this.replySize}`];
9696

9797
const response = await fetch(
9898
`${this.baseUrl}/apis/api.halo.run/v1alpha1/comments/${this.comment?.metadata.name}/reply?${queryParams.join('&')}`
@@ -122,8 +122,14 @@ export class CommentReplies extends LitElement {
122122
}
123123

124124
async fetchNext() {
125-
this.page++;
126-
await this.fetchReplies({ append: true });
125+
if (this.withReplies) {
126+
// if withReplies is true, we need to reload the replies list
127+
await this.fetchReplies({ append: !(this.page === 1) });
128+
this.page++;
129+
} else {
130+
this.page++;
131+
await this.fetchReplies({ append: true });
132+
}
127133
}
128134

129135
override connectedCallback(): void {

src/main/resources/extensions/settings.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,12 +8,12 @@ spec:
88
label: 基本设置
99
formSchema:
1010
- $formkit: number
11-
label: 默认加载评论条数
11+
label: 评论分页条数
1212
name: size
1313
validation: required
1414
value: 20
1515
- $formkit: number
16-
label: 默认加载回复条数
16+
label: 回复分页条数
1717
name: replySize
1818
validation: required
1919
value: 10

0 commit comments

Comments
 (0)