Skip to content

Complete Simplified Chinese scenario localization#5155

Open
llwwbb wants to merge 10 commits into
halogenandtoast:mainfrom
llwwbb:codex/complete-simplified-chinese-localization
Open

Complete Simplified Chinese scenario localization#5155
llwwbb wants to merge 10 commits into
halogenandtoast:mainfrom
llwwbb:codex/complete-simplified-chinese-localization

Conversation

@llwwbb

@llwwbb llwwbb commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

Dependency

This draft PR is based on #5138 and includes its two commits. Please review and merge #5138 first; once it is merged, this PR's remaining diff will be the Simplified Chinese scenario localization commit.

Summary

  • add a dedicated zh-cn UI locale without changing the existing Traditional Chinese zh locale
  • translate all campaign, standalone, and supported homebrew scenario text into Simplified Chinese
  • add general locale integrity checks for file/key coverage, locale-neutral keys, and English fallbacks

Test plan

  • npm test
  • npm run tc
  • npx vite build

@llwwbb
llwwbb force-pushed the codex/complete-simplified-chinese-localization branch from b69a4d4 to a6fcb0e Compare July 15, 2026 02:47
@llwwbb llwwbb closed this Jul 15, 2026
@github-project-automation github-project-automation Bot moved this from Todo to Done in Arkham Issues Jul 15, 2026
@llwwbb llwwbb reopened this Jul 15, 2026
@llwwbb
llwwbb marked this pull request as draft July 15, 2026 02:59
llwwbb added 4 commits July 15, 2026 14:14
…lified-chinese-localization

# Conflicts:
#	backend/arkham-api/arkham-api.cabal
#	backend/arkham-api/library/Arkham/Location/Cards/CircusEncampmentCircusExMortis.hs
@llwwbb
llwwbb marked this pull request as ready for review July 17, 2026 02:47
@llwwbb

llwwbb commented Jul 17, 2026

Copy link
Copy Markdown
Contributor Author

Now that #5138 has been merged, I have one question about card images for the new Simplified Chinese (zh-cn) locale.

Would you prefer zh-cn to reuse the existing Chinese (zh) card image pack? During playtesting, I found quite a few inaccuracies and mismatched card images in the current Chinese pack, so linking it by default may give Simplified Chinese users a confusing experience.

One option would be to keep zh-cn separate and fall back to the English card images for now, until a more reliable Simplified Chinese image pack is available. Do you have a preference, or a better idea for how this mapping should be handled?

llwwbb added 2 commits July 17, 2026 10:58
…lified-chinese-localization

# Conflicts:
#	frontend/src/locales/language.ts
#	frontend/src/locales/messages.ts
#	frontend/tests/language.test.mjs
@halogenandtoast

Copy link
Copy Markdown
Owner

Would you prefer zh-cn to reuse the existing Chinese (zh) card image pack? During playtesting, I found quite a few inaccuracies and mismatched card images in the current Chinese pack, so linking it by default may give Simplified Chinese users a confusing experience.

One option would be to keep zh-cn separate and fall back to the English card images for now, until a more reliable Simplified Chinese image pack is available. Do you have a preference, or a better idea for how this mapping should be handled?

I don't have enough language context to know which is best here. But I feel like falling back to English for now is probably best.

…lified-chinese-localization

# Conflicts:
#	backend/arkham-api/library/Arkham/Asset/Assets/DecayDiagram.hs
#	backend/arkham-api/library/Arkham/Location/Cards/LabyrinthineHallsOvergrownPath.hs
#	backend/arkham-api/library/Arkham/Story/Cards/AnomaliesInSpacetime.hs
#	frontend/src/locales/en/standalone/theLabyrinthsOfLunacy.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants