Use public hamma.diagnostic_data in NoiseDiag plugin (low priority)#67
Draft
pbitzer wants to merge 1 commit into
Draft
Use public hamma.diagnostic_data in NoiseDiag plugin (low priority)#67pbitzer wants to merge 1 commit into
pbitzer wants to merge 1 commit into
Conversation
hamma 0.3.0 made diagnostic_data public; switch the plugin and its test patches from the private _diagnostic_data to the top-level re-export. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Switches the
NoiseDiagplugin (plugins/noise_diag.py) from the privatehamma.header.core._diagnostic_datato the publichamma.diagnostic_data(released in hamma 0.3.0). This is the last consumer in the shared-noise-primitive consolidation — the on-demandscripts/hamma_noise.pyswap already shipped in 0.4.0 (PR #52, commitffa73c2).plugins/noise_diag.py:from hamma import diagnostic_data; call site uses it, arguments unchanged.tests/python/test_noise_diag.pyupdated to the new path. 11 passed.diagnostic_datareturns the same(median, max, min, noise)).Draft / no rush
NoiseDiag works as-is on 0.4.0: hamma 0.3.0 deliberately retains
_diagnostic_dataas a deprecated alias, so the plugin resolves on every sensor (0.2a and 0.3.0). This is hygiene (use the public name), not a bug fix — fine to ride the next release with other content rather than cut a release just for it.Dependency / rollout
Once merged + deployed, the plugin imports the public name directly, so it needs
hamma >= 0.3.0on the sensor — the same dependency 0.4.0 already declares. Keep it aligned with the coordinated fleet-to-0.3.0 rollout.🤖 Generated with Claude Code