Add Morningstar ProStar MPPT charge controller preset#1
Open
pbitzer wants to merge 2 commits into
Open
Conversation
The ProStar MPPT uses IEEE 754 half-precision floats (not the fixed-point scale/base/power encoding from the SunSaver). Verified against the official Modbus spec (MS-001723 v05). Also adds the complete register map (54 data channels, 61 registers), the [inputs.ram] section, and _dependencies. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
jcburchfield
approved these changes
May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
input_type = "e") for measurement registers, verified against the official Modbus spec (MS-001723 v05)Key design decisions
n * scale * 2^-15. Usinginput_type = "e"lets Python'sstructmodule decode them directly with no conversion math needed.input_typenotbinary_type: Required for Modbus presets because Brokkr'sModbusInputsets a defaultinput_type = "H"that would overridebinary_type. This matches the sunsaver's approach.input_type = "I"with HI-word-first ordering, matching the spec's big-endian layout.Test plan
🤖 Generated with Claude Code