Use Convert.ToHexStringLower() in C##458
Closed
xakep139 wants to merge 4 commits intohanabi1224:mainfrom
Closed
Conversation
Contributor
Author
|
@hanabi1224 if this approach looks good, then I can update other usages - https://github.com/search?q=repo%3Ahanabi1224%2FProgramming-Language-Benchmarks+ToHexString+language%3AC%23&type=code&l=C%23 |
Owner
|
Thanks, LGTM. |
Contributor
Author
Done, please review |
Contributor
Author
|
So, the build error is: Since Mono's implementation of @hanabi1224 FYI, as more and more new .NET APIs won't work with Mono compiler. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There's a bunch of custom-made
ToHexString()methods with the same implementation. As per Performance Improvements in .NET 9, it's better to use built-in and optimizedConvert.ToHexStringLower()method.That way, it will both (a) reduce code duplication and (b) slightly improve performance.